You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/11/02 19:23:38 UTC

[kudu-CR] scripts: better documentation for get-job-stats-from-mysql.py 

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8453

to review the following change.


Change subject: scripts: better documentation for get-job-stats-from-mysql.py
......................................................................

scripts: better documentation for get-job-stats-from-mysql.py

The parameter named 'job_name' was (confusingly) substituted in as the
query's workload.

Change-Id: I3d26c783d66b9420d5ced50363c9421e7c1944bc
---
M src/kudu/scripts/get-job-stats-from-mysql.py
1 file changed, 19 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/8453/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d26c783d66b9420d5ced50363c9421e7c1944bc
Gerrit-Change-Number: 8453
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] scripts: better documentation for get-job-stats-from-mysql.py

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8453 )

Change subject: scripts: better documentation for get-job-stats-from-mysql.py
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d26c783d66b9420d5ced50363c9421e7c1944bc
Gerrit-Change-Number: 8453
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 03 Nov 2017 00:05:39 +0000
Gerrit-HasComments: No

[kudu-CR] scripts: better documentation for get-job-stats-from-mysql.py

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8453 )

Change subject: scripts: better documentation for get-job-stats-from-mysql.py
......................................................................

scripts: better documentation for get-job-stats-from-mysql.py

The parameter named 'job_name' was (confusingly) substituted in as the
query's workload.

Change-Id: I3d26c783d66b9420d5ced50363c9421e7c1944bc
Reviewed-on: http://gerrit.cloudera.org:8080/8453
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/scripts/get-job-stats-from-mysql.py
1 file changed, 19 insertions(+), 3 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Todd Lipcon: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/8453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d26c783d66b9420d5ced50363c9421e7c1944bc
Gerrit-Change-Number: 8453
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>