You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/10/04 22:02:32 UTC
[jira] Created: (LUCENE-2687) Remove Priority-Queue size trap in
MultiTermQuery.TopTermsBooleanQueryRewrite
Remove Priority-Queue size trap in MultiTermQuery.TopTermsBooleanQueryRewrite
-----------------------------------------------------------------------------
Key: LUCENE-2687
URL: https://issues.apache.org/jira/browse/LUCENE-2687
Project: Lucene - Java
Issue Type: Improvement
Components: Search
Affects Versions: 3.1, 4.0
Reporter: Robert Muir
Priority: Minor
Fix For: 3.1, 4.0
These APIs are new in 3.x, so we can do this with no backwards-compatibility issue:
Before 3.1, FuzzyQuery had its own internal rewrite method.
We exposed this in 3.x as TopTermsBooleanQueryRewrite, and then as subclasses for Scoring and Boost-only variants.
The problem I have is that the PQ has a default (large) size of Integer.MAX_VALUE... of course its later limited by
the value of BooleanQuery's maxClauseCount, but I think this is a trap.
Instead its better to simply remove these defaults and force the user to provide a default (reasonable) size.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2687) Remove Priority-Queue size trap in
MultiTermQuery.TopTermsBooleanQueryRewrite
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2687:
--------------------------------
Attachment: LUCENE-2687.patch
all tests pass with the fix.
> Remove Priority-Queue size trap in MultiTermQuery.TopTermsBooleanQueryRewrite
> -----------------------------------------------------------------------------
>
> Key: LUCENE-2687
> URL: https://issues.apache.org/jira/browse/LUCENE-2687
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 3.1, 4.0
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2687.patch
>
>
> These APIs are new in 3.x, so we can do this with no backwards-compatibility issue:
> Before 3.1, FuzzyQuery had its own internal rewrite method.
> We exposed this in 3.x as TopTermsBooleanQueryRewrite, and then as subclasses for Scoring and Boost-only variants.
> The problem I have is that the PQ has a default (large) size of Integer.MAX_VALUE... of course its later limited by
> the value of BooleanQuery's maxClauseCount, but I think this is a trap.
> Instead its better to simply remove these defaults and force the user to provide a default (reasonable) size.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2687) Remove Priority-Queue size trap in
MultiTermQuery.TopTermsBooleanQueryRewrite
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2687.
---------------------------------
Resolution: Fixed
Assignee: Robert Muir
Committed revision 1005310, 1005312 (3x)
> Remove Priority-Queue size trap in MultiTermQuery.TopTermsBooleanQueryRewrite
> -----------------------------------------------------------------------------
>
> Key: LUCENE-2687
> URL: https://issues.apache.org/jira/browse/LUCENE-2687
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 3.1, 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2687.patch
>
>
> These APIs are new in 3.x, so we can do this with no backwards-compatibility issue:
> Before 3.1, FuzzyQuery had its own internal rewrite method.
> We exposed this in 3.x as TopTermsBooleanQueryRewrite, and then as subclasses for Scoring and Boost-only variants.
> The problem I have is that the PQ has a default (large) size of Integer.MAX_VALUE... of course its later limited by
> the value of BooleanQuery's maxClauseCount, but I think this is a trap.
> Instead its better to simply remove these defaults and force the user to provide a default (reasonable) size.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org