[GitHub] [activemq-artemis] jbertram commented on a change in pull request #2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8

[GitBox <gi...@apache.org>]

jbertram commented on a change in pull request #2990: ARTEMIS-2627 simpleSecureServer failing on IBM JDK 8
URL: https://github.com/apache/activemq-artemis/pull/2990#discussion_r382701110
 
 

 ##########
 File path: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
 ##########
 @@ -72,6 +74,11 @@ public void configure(ComponentDTO config, String artemisInstance, String artemi
          SslContextFactory.Server sslFactory = new SslContextFactory.Server();
          sslFactory.setKeyStorePath(webServerConfig.keyStorePath == null ? artemisInstance + "/etc/keystore.jks" : webServerConfig.keyStorePath);
          sslFactory.setKeyStorePassword(webServerConfig.getKeyStorePassword() == null ? "password" : webServerConfig.getKeyStorePassword());
+         sslFactory.setIncludeProtocols("TLSv1.2");
 
 Review comment:
   I'm concerned about changing the default here for all cases. This should probably be made configurable and then the test can configure it as necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services