You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/08 05:16:24 UTC
[GitHub] [spark] bersprockets opened a new pull request, #36481: [SPARK-39093][SQL][FOLLOWUP] Fix Period test
bersprockets opened a new pull request, #36481:
URL: https://github.com/apache/spark/pull/36481
### What changes were proposed in this pull request?
Change the Period test to use months rather than days.
### Why are the changes needed?
While the Period test as-is confirms that the compilation error is fixed, it doesn't confirm that the newly generated code is correct. Spark ignores any unit less than months in Periods. As a result, we are always testing `0/(num + 3)`, so the test doesn't verify that the code generated for the right-hand operand is correct.
### Does this PR introduce _any_ user-facing change?
No, only changes a test.
### How was this patch tested?
Unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #36481: [SPARK-39093][SQL][FOLLOWUP] Fix Period test
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #36481:
URL: https://github.com/apache/spark/pull/36481#issuecomment-1120389961
Thanks, merging to master/3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #36481: [SPARK-39093][SQL][FOLLOWUP] Fix Period test
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #36481: [SPARK-39093][SQL][FOLLOWUP] Fix Period test
URL: https://github.com/apache/spark/pull/36481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org