You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2007/01/29 22:12:49 UTC

[jira] Created: (SOLR-124) use LUCENE-565

use LUCENE-565
--------------

                 Key: SOLR-124
                 URL: https://issues.apache.org/jira/browse/SOLR-124
             Project: Solr
          Issue Type: Improvement
          Components: update
            Reporter: Yonik Seeley


LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley closed SOLR-124.
-----------------------------

       Resolution: Duplicate
    Fix Version/s: 1.3

> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>             Fix For: 1.3
>
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481238 ] 

Hoss Man commented on SOLR-124:
-------------------------------

no patch exists yet ... this issue was opened to track that it *should* be done at some point.

i believe it will be a somewhat significant change, but i'm not much of an expert on the update internals.

> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Tim Patton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481247 ] 

Tim Patton commented on SOLR-124:
---------------------------------

Oh I read "LUCEUE-565 has been committed" as meaning Yonik had committed the code to some branch or had at least checked the code worked but was waiting to commit it in to the trunk.  

If one were to work on this, would it be easier to work from DU2 or the original DU?  It looks like DU2 duplicates a lot of features of the new IndexWriter and DU would be a more straitforward starting point.

> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Tim Patton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481163 ] 

Tim Patton commented on SOLR-124:
---------------------------------

I see that Lucene 2.1 is out and the latest DL of Solr that I got had the jars.  Will this patch be added in soon, or is it available somewhere now?

> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-124:
------------------------------

    Summary: use NewIndexModifier, LUCENE-565  (was: use LUCENE-565)

LUCEUE-565 has been committed, but Solr doesn't have that version yet.
Lucene 2.1 is right around the corner though.

> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481264 ] 

Mike Klaas commented on SOLR-124:
---------------------------------

DUH may be simpler, but DUH2 has also been carefully modified to safely support multithreaded indexing and autocommitting.

Does anyone have a feeling on whether LUCENE-565 will improve performance?  Or is it likely to be mostly a code cleansliness improvement?

> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Tim Patton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483194 ] 

Tim Patton commented on SOLR-124:
---------------------------------

Which package protected parts of lucene would need to be accessed?  Perhaps a patch to lucene could be submitted to support dleete by query (or at least all easy support of delete by query).

> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482414 ] 

Yonik Seeley commented on SOLR-124:
-----------------------------------

> Does anyone have a feeling on whether LUCENE-565 will improve performance?

Probably not much, if at all.  Deletions happen after a segment flush, which is slightly less efficient (more indexreaders that need to be opened), but does get deletions in the index faster (meaning they are more likely to be "squeezed" out by a subsequent segment merge).

One small advantage to LUCENE-565 is that overwriting is atomic... you can't crash and see duplicates.

The patch has been changed around multiple times, and it would now be necessary to include a lucene package in solr to get access to package-protected stuff that would allow efficient delete-by-query.


> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599363#action_12599363 ] 

Koji Sekiguchi commented on SOLR-124:
-------------------------------------

I could be wrong but is this duplicate of SOLR-559?

> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-124) use NewIndexModifier, LUCENE-565

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599369#action_12599369 ] 

Yonik Seeley commented on SOLR-124:
-----------------------------------

Yes it is mostly a duplicate (I did a search before I opened 559, but didn't turn up this one).

I had been planning on having to implement our own deleteByQuery efficiently w/ certain IndexWriter extension points, but Lucene now has deleteByQuery in trunk, so we should just wait for that.


> use NewIndexModifier, LUCENE-565
> --------------------------------
>
>                 Key: SOLR-124
>                 URL: https://issues.apache.org/jira/browse/SOLR-124
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>
> LUCENE-565 adds extension points to the IndexWriter, and adds delete-by-term functionality.
> We should probably take advantage of this (when available) in our UpdateHandler (a new one, or modify DU2?)
> and perhaps implement a more efficient deleteByQuery.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.