[GitHub] [spark] cloud-fan commented on a change in pull request #27733: Revert "[SPARK-30808][SQL] Enable Java 8 time API in Thrift server"

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27733: Revert "[SPARK-30808][SQL] Enable Java 8 time API in Thrift server"
URL: https://github.com/apache/spark/pull/27733#discussion_r385610546
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
 ##########
 @@ -378,6 +378,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
         localSparkSession.conf.set(SQLConf.ANSI_ENABLED.key, true)
       case _ =>
     }
+    localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true)
 
 Review comment:
   can we remove this? 
   
   The main goal of #27552 is to remove this line. If we can remove it and still pass all tests, then #27552 can be safely removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org