You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by anyway1021 <gi...@git.apache.org> on 2016/07/14 14:43:43 UTC
[GitHub] incubator-eagle pull request #267: Eagle 376 skip false failing hbase relate...
GitHub user anyway1021 opened a pull request:
https://github.com/apache/incubator-eagle/pull/267
Eagle 376 skip false failing hbase related UT code
These faulty UT cases constantly failed because the embeded hbase environment cannot be started up properly, thus they have produced many false failures for long and wasted a lot of building time. Now skip them to so that the normal UT cases can expose true issues if there is any.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anyway1021/incubator-eagle EAGLE-376
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
----
commit 10cc46395a1b98e798ea6704a03ae9c938800335
Author: anyway1021 <mw...@apache.org>
Date: 2016-07-14T08:02:20Z
skip hbase related UT in sub-module: eagle-embed-hbase, to avoid false failures
commit de884c9480c606533c14843ae2afff040fdccdb2
Author: anyway1021 <mw...@apache.org>
Date: 2016-07-14T08:56:17Z
skip hbase related UT in sub-module: eagle-entity-base, to avoid false failures
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #267: Eagle 376 skip false failing hbase related UT co...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:
https://github.com/apache/incubator-eagle/pull/267
LGTM for this pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #267: Eagle 376 skip false failing hbase related UT co...
Posted by anyway1021 <gi...@git.apache.org>.
Github user anyway1021 commented on the issue:
https://github.com/apache/incubator-eagle/pull/267
@qingwen220 this PR and jira ticket is not for fixing problems of siddhi, it's just for skipping hbase related UT cases. The failure you pasted is out of the scope of it. I'll try to research and fix them in another thread.
Could you re-consider your judgement based on the above? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #267: Eagle 376 skip false failing hbase relate...
Posted by anyway1021 <gi...@git.apache.org>.
Github user anyway1021 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #267: Eagle 376 skip false failing hbase related UT co...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:
https://github.com/apache/incubator-eagle/pull/267
@anyway1021 I found the following log in Jenkins log
Results :
Failed tests:
testSlideWindow1(org.apache.eagle.alert.siddhi.TestSiddhiSlideWindow)
Tests in error:
testTimeSlideWindow(org.apache.eagle.alert.state.TestSiddhiStateSnapshotAndRestore)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---