You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/03/01 16:09:58 UTC

[GitHub] [openwhisk-runtime-rust] rabbah opened a new pull request #29: Update Dockerfile build from source stanza.

rabbah opened a new pull request #29:
URL: https://github.com/apache/openwhisk-runtime-rust/pull/29


   This follows the pattern used in other repos to allow builds to select where to build source from.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-runtime-rust] rabbah merged pull request #29: Update Dockerfile build from source stanza.

Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #29:
URL: https://github.com/apache/openwhisk-runtime-rust/pull/29


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-runtime-rust] rabbah commented on a change in pull request #29: Update Dockerfile build from source stanza.

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #29:
URL: https://github.com/apache/openwhisk-runtime-rust/pull/29#discussion_r584963251



##########
File path: core/rust1.34/Dockerfile
##########
@@ -17,7 +17,12 @@
 
 # build go proxy from source
 FROM golang:1.15 AS builder_source
-RUN env CGO_ENABLED=0 go get github.com/apache/openwhisk-runtime-go/main && mv /go/bin/main /bin/proxy
+ARG GO_PROXY_GITHUB_USER=nimbella-corp

Review comment:
       Thanks for catching that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-runtime-rust] dgrove-oss commented on a change in pull request #29: Update Dockerfile build from source stanza.

Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #29:
URL: https://github.com/apache/openwhisk-runtime-rust/pull/29#discussion_r584916516



##########
File path: core/rust1.34/Dockerfile
##########
@@ -17,7 +17,12 @@
 
 # build go proxy from source
 FROM golang:1.15 AS builder_source
-RUN env CGO_ENABLED=0 go get github.com/apache/openwhisk-runtime-go/main && mv /go/bin/main /bin/proxy
+ARG GO_PROXY_GITHUB_USER=nimbella-corp

Review comment:
       apache and master?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org