You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/12/06 00:36:51 UTC

Review guidelines doc

We have a lot of components in sqoop and some of us have more knowledge in
a few than others

I have created a wiki for review guidelines per component. Gwen also added
her thoughts, this is to help reviewers watch out for pitfalls.

https://cwiki.apache.org/confluence/display/SQOOP/Sqoop+2+Review+Guidelines

Would be nice to have more details on things to watch out for per component
when reviewing and even create a component reviewer we should reach out for
reviews.

For example
HDFSConnector - Gwen
Kite Connector - Stanley
Security - Richard
Integration Test - Jarcec
Postgres - Abe
Derby - anyone!

I must be obsessed with docs.!!


Best,
*./Vee*

Re: Review guidelines doc

Posted by Veena Basavaraj <vb...@cloudera.com>.

Thanks, Please feel free to edit it ! we all can contribute to it.




Best,
*./Vee*

On Thu, Dec 11, 2014 at 8:31 AM, Abraham Elmahrek <ab...@cloudera.com> wrote:

> Veena,
>
> This looks really good. I have a couple of thoughts/comments. Should I add
> them in the comments section of the wiki?
>
> -Abe
>
> On Fri, Dec 5, 2014 at 5:36 PM, Veena Basavaraj <vb...@cloudera.com>
> wrote:
>
> > We have a lot of components in sqoop and some of us have more knowledge
> in
> > a few than others
> >
> > I have created a wiki for review guidelines per component. Gwen also
> added
> > her thoughts, this is to help reviewers watch out for pitfalls.
> >
> >
> https://cwiki.apache.org/confluence/display/SQOOP/Sqoop+2+Review+Guidelines
> >
> > Would be nice to have more details on things to watch out for per
> component
> > when reviewing and even create a component reviewer we should reach out
> for
> > reviews.
> >
> > For example
> > HDFSConnector - Gwen
> > Kite Connector - Stanley
> > Security - Richard
> > Integration Test - Jarcec
> > Postgres - Abe
> > Derby - anyone!
> >
> > I must be obsessed with docs.!!
> >
> >
> > Best,
> > *./Vee*
> >
>

Re: Review guidelines doc

Posted by Abraham Elmahrek <ab...@cloudera.com>.

Veena,

This looks really good. I have a couple of thoughts/comments. Should I add
them in the comments section of the wiki?

-Abe

On Fri, Dec 5, 2014 at 5:36 PM, Veena Basavaraj <vb...@cloudera.com>
wrote:

> We have a lot of components in sqoop and some of us have more knowledge in
> a few than others
>
> I have created a wiki for review guidelines per component. Gwen also added
> her thoughts, this is to help reviewers watch out for pitfalls.
>
> https://cwiki.apache.org/confluence/display/SQOOP/Sqoop+2+Review+Guidelines
>
> Would be nice to have more details on things to watch out for per component
> when reviewing and even create a component reviewer we should reach out for
> reviews.
>
> For example
> HDFSConnector - Gwen
> Kite Connector - Stanley
> Security - Richard
> Integration Test - Jarcec
> Postgres - Abe
> Derby - anyone!
>
> I must be obsessed with docs.!!
>
>
> Best,
> *./Vee*
>