You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/25 04:51:13 UTC
[GitHub] [superset] ktmud opened a new pull request #13329: test: optimize codecov config
ktmud opened a new pull request #13329:
URL: https://github.com/apache/superset/pull/13329
### SUMMARY
Optimize CodeCov config to
1. Always let GitHub CodeCov checks pass because we don't always report all test coverage (because of [conditional CI jobs](https://github.com/apache/superset/pull/12583))
2. Add more detailed flags for coverage [uploads](https://codecov.io/gh/apache/superset/commit/a700205d75abf8ad628e063c3bbf12c8625330fc/build)
It seems the CodeCov App has recently been enabled in this repo (#9930), which is good, but it starts to block block some PRs on status check due to false alarms of decreased test coverage. This is because:
1. The target coverage setting is set to "auto", which will report any decrease in test coverage
2. We conditionally skip Python tests for pure frontend changes (and vice versa), hence certain PRs will never have the full test coverage reported.
3. Sometimes frontend and backend workflows are delayed in queue and run in very different time. After wait for a while, CodeCov may come to believe the full CI has finished, therefore reporting only partial coverage from the already finished jobs.
The [`after_n_builds`](https://docs.codecov.io/docs/notifications) config is designed to address this issue, but since we don't know which jobs will run for each PR, we can't really set a meaningful value for this config.
I'm setting it to 4 because for Python tests there are 5 uploads (mysql, postgres, sqlite, hive, presto), and for frontend, there are 4 ([unit tests](https://github.com/apache/superset/blob/59d4e8759a0490e6b5bca8cfa87cbf1191b486d2/.github/workflows/superset-frontend.yml#L48) + Cypress * 3).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
- CI Passes and flags correctly marked on CodeCov
<img width="1166" alt="commit-flags" src="https://user-images.githubusercontent.com/335541/109105029-f9775a80-76e1-11eb-8147-7859b9f0cba7.png">
- GH checks are not blocked by CodeCov
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13329: test: optimize codecov config
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13329:
URL: https://github.com/apache/superset/pull/13329#issuecomment-785650380
# [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=h1) Report
> Merging [#13329](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=desc) (c694ee9) into [master](https://codecov.io/gh/apache/superset/commit/8ab45c90ccc04f51a0e7db12b622fb63a29ec27c?el=desc) (8ab45c9) will **decrease** coverage by `5.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13329 +/- ##
==========================================
- Coverage 77.08% 72.03% -5.05%
==========================================
Files 876 876
Lines 45439 45409 -30
Branches 5440 5440
==========================================
- Hits 35026 32712 -2314
- Misses 10290 12487 +2197
- Partials 123 210 +87
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.27% <ø> (ø)` | |
| mysql | `80.30% <ø> (?)` | |
| postgres | `80.35% <ø> (?)` | |
| python | `80.43% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `79.96% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/filters/components/Time/types.ts](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3R5cGVzLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [209 more](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=footer). Last update [8ab45c9...5ccc773](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13329: test: optimize codecov config
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13329:
URL: https://github.com/apache/superset/pull/13329#issuecomment-785650380
# [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=h1) Report
> Merging [#13329](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=desc) (c694ee9) into [master](https://codecov.io/gh/apache/superset/commit/8ab45c90ccc04f51a0e7db12b622fb63a29ec27c?el=desc) (8ab45c9) will **decrease** coverage by `5.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13329 +/- ##
==========================================
- Coverage 77.08% 72.03% -5.05%
==========================================
Files 876 876
Lines 45439 45409 -30
Branches 5440 5440
==========================================
- Hits 35026 32712 -2314
- Misses 10290 12487 +2197
- Partials 123 210 +87
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.27% <ø> (ø)` | |
| mysql | `80.30% <ø> (?)` | |
| postgres | `80.34% <ø> (?)` | |
| python | `80.43% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `79.96% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/filters/components/Time/types.ts](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3R5cGVzLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [209 more](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=footer). Last update [8ab45c9...5ccc773](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett merged pull request #13329: test: optimize codecov config
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #13329:
URL: https://github.com/apache/superset/pull/13329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13329: test: optimize codecov config
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13329:
URL: https://github.com/apache/superset/pull/13329#issuecomment-785650380
# [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=h1) Report
> Merging [#13329](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=desc) (c694ee9) into [master](https://codecov.io/gh/apache/superset/commit/8ab45c90ccc04f51a0e7db12b622fb63a29ec27c?el=desc) (8ab45c9) will **decrease** coverage by `0.71%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13329 +/- ##
==========================================
- Coverage 77.08% 76.36% -0.72%
==========================================
Files 876 876
Lines 45439 45439
Branches 5440 5440
==========================================
- Hits 35026 34699 -327
- Misses 10290 10611 +321
- Partials 123 129 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.56% <ø> (-2.61%)` | :arrow_down: |
| javascript | `62.27% <ø> (ø)` | |
| mysql | `80.30% <ø> (?)` | |
| postgres | `80.34% <ø> (?)` | |
| python | `80.43% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `79.96% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset-frontend/src/utils/copy.ts](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvcHkudHM=) | `11.53% <0.00%> (-80.77%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useUrlShortener.ts](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VVcmxTaG9ydGVuZXIudHM=) | `50.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-25.81%)` | :arrow_down: |
| [...rols/MetricControl/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXJUaXRsZS5qc3g=) | `70.58% <0.00%> (-20.59%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `57.05% <0.00%> (-15.34%)` | :arrow_down: |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `61.26% <0.00%> (-14.42%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=footer). Last update [8ab45c9...5ccc773](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13329: test: optimize codecov config
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13329:
URL: https://github.com/apache/superset/pull/13329#issuecomment-785650380
# [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=h1) Report
> Merging [#13329](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=desc) (c694ee9) into [master](https://codecov.io/gh/apache/superset/commit/8ab45c90ccc04f51a0e7db12b622fb63a29ec27c?el=desc) (8ab45c9) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13329 +/- ##
==========================================
- Coverage 77.08% 77.01% -0.07%
==========================================
Files 876 876
Lines 45439 45439
Branches 5440 5440
==========================================
- Hits 35026 34997 -29
- Misses 10290 10319 +29
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.16% <ø> (ø)` | |
| hive | `79.97% <ø> (?)` | |
| javascript | `62.27% <ø> (ø)` | |
| mysql | `80.30% <ø> (?)` | |
| postgres | `80.34% <ø> (?)` | |
| python | `80.73% <ø> (-0.12%)` | :arrow_down: |
| sqlite | `79.96% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.47% <0.00%> (-5.99%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=footer). Last update [8ab45c9...5ccc773](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13329: test: optimize codecov config
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13329:
URL: https://github.com/apache/superset/pull/13329#issuecomment-785650380
# [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=h1) Report
> Merging [#13329](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=desc) (c694ee9) into [master](https://codecov.io/gh/apache/superset/commit/8ab45c90ccc04f51a0e7db12b622fb63a29ec27c?el=desc) (8ab45c9) will **decrease** coverage by `0.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13329 +/- ##
==========================================
- Coverage 77.08% 76.85% -0.23%
==========================================
Files 876 876
Lines 45439 45439
Branches 5440 5440
==========================================
- Hits 35026 34923 -103
- Misses 10290 10393 +103
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.16% <ø> (ø)` | |
| javascript | `62.27% <ø> (ø)` | |
| mysql | `80.30% <ø> (?)` | |
| postgres | `80.34% <ø> (?)` | |
| python | `80.43% <ø> (-0.43%)` | :arrow_down: |
| sqlite | `79.96% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=footer). Last update [8ab45c9...5ccc773](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13329: test: optimize codecov config
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13329:
URL: https://github.com/apache/superset/pull/13329#issuecomment-785650380
# [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=h1) Report
> Merging [#13329](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=desc) (c694ee9) into [master](https://codecov.io/gh/apache/superset/commit/8ab45c90ccc04f51a0e7db12b622fb63a29ec27c?el=desc) (8ab45c9) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13329 +/- ##
==========================================
- Coverage 77.08% 77.01% -0.07%
==========================================
Files 876 876
Lines 45439 45439
Branches 5440 5440
==========================================
- Hits 35026 34996 -30
- Misses 10290 10320 +30
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.16% <ø> (ø)` | |
| hive | `79.97% <ø> (?)` | |
| javascript | `62.27% <ø> (ø)` | |
| mysql | `80.30% <ø> (?)` | |
| postgres | `80.34% <ø> (?)` | |
| python | `80.73% <ø> (-0.13%)` | :arrow_down: |
| sqlite | `79.96% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.47% <0.00%> (-5.99%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13329/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=footer). Last update [8ab45c9...5ccc773](https://codecov.io/gh/apache/superset/pull/13329?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org