[GitHub] [tvm] manupa-arm commented on a change in pull request #9160: [ETHOSN] Match config for is-supported with compilation target

[GitBox <gi...@apache.org>]

manupa-arm commented on a change in pull request #9160:
URL: https://github.com/apache/tvm/pull/9160#discussion_r734327562



##########
File path: src/relay/backend/contrib/ethosn/codegen_ethosn.h
##########
@@ -322,6 +338,8 @@ class EthosnCompiler {
    */
   static std::pair<std::vector<uint32_t>, std::vector<uint32_t>> GetInputOutputOrder(
       NetworkWithIDs network, const std::unique_ptr<sl::CompiledNetwork>& compiled_network);
+
+  static std::unique_ptr<sl::SupportQueries> m_Queries;

Review comment:
       Please add docs.

##########
File path: src/relay/backend/contrib/ethosn/codegen.cc
##########
@@ -606,25 +606,37 @@ std::pair<std::vector<uint32_t>, std::vector<uint32_t>> EthosnCompiler::GetInput
   return std::make_pair(input_order, output_order);
 }
 
-auto ctx = transform::PassContext::Current();
-auto cfg = ctx -> GetConfig<EthosnCompilerConfig>("relay.ext.ethos-n.options").defined()
-               ? ctx -> GetConfig<EthosnCompilerConfig>("relay.ext.ethos-n.options")
-               : AttrsWithDefaultValues<EthosnCompilerConfig>();
-auto m_Queries = sl::SupportQueries(sl::GetFwAndHwCapabilities(
-    sl::EthosNVariantFromString(cfg.value()->variant.c_str()), cfg.value()->sram_size_bytes));
+std::unique_ptr<sl::SupportQueries> EthosnCompiler::m_Queries;

Review comment:
       nit : Do we need this line ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org