[GitHub] [shiro-site] bdemers commented on a change in pull request #150: [SHIRO-866] 1.9.0 update and announcement

[GitBox <gi...@apache.org>]

bdemers commented on a change in pull request #150:
URL: https://github.com/apache/shiro-site/pull/150#discussion_r806092807



##########
File path: CONTRIBUTING.adoc
##########
@@ -11,13 +30,14 @@ Git will automatically convert line endings for you.
 
 === Changes to link:data/releases.yaml[]
 
-* If the new `latestRelease` is a new minor release (e.g. `1.x.0`), prepend the old version to the `oldReleases` array. +
-Please skip this step for minor releases.
-* If the new `latestRelease` is a minor release, update the version number of the `releases` object at the end of the file. +
-_Rationale:_ Every minor release should only be represented with the latest bugfix release.
 * Change `latestRelease: "..."` to the new version.
 * Update the `versionInfo` object accordingly. +
 You can just add a new release, there is no need to remove old releases.
+* Update the `oldReleases`/`releases` variable like so:
+** If the new `latestRelease` is a new minor release (e.g. `1.n.0`, where `n` is the new minor release version), prepend the old version to the `oldReleases` array. +
+Also add it to the 'releases' object at the end of the file as `1nx`.
+** If the new `latestRelease` is a bugfix release (e.g. `1.n.x`), update the version number of the `releases` object at the end of the file. +
+_Rationale:_ Every minor release should only be represented with the latest bugfix release.

Review comment:
       ```suggestion
   * Update the `oldReleases`/`releases` variable:
   ** If the new `latestRelease` is a new minor release (e.g. `1.n.0`, where `n` is the new minor release version), prepend the old version to the `oldReleases` array. +
   Also, add it to the 'releases' object at the end of the file as `1nx`.
   ** If the new `latestRelease` is a bugfix release (e.g. `1.n.x`), update the version number of the `releases` object at the end of the file. +
   _Rationale:_ Every minor release should only be represented with the latest bugfix release.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org