You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2016/03/15 19:31:29 UTC
[GitHub] couchdb-fauxton pull request: Notifications update
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/668
Notifications update
This updates the global notifications to use the same store as the notification panel, drop Backbone.
I chose to build it on Garren's Webpack branch: https://github.com/apache/couchdb-fauxton/pull/641 because I needed to include Velocity-React and it would have been a hack getting it into our current master, due to some fussy dependencies. Now it's just a simple matter of including it in the package.json file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton notifications-update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/668.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #668
----
commit 535ab17f73258e23f881c4375b33e3035d628a79
Author: Garren Smith <ga...@gmail.com>
Date: 2016-02-04T12:36:29Z
Change from requirejs to webpack
This gives us the benefits of managing our dependencies via npm. It also
means we can support the latest react and control all our transpiling
and minifying via webpack.
commit 9aeeb8b522db034821a1d682702d9d6d13d8ec4f
Author: Garren Smith <ga...@gmail.com>
Date: 2016-02-22T16:45:51Z
Remove old libraries
Remove dependancies no longer needed. These are all now managed via
webpack and npm
commit 508aaf17113b54e1f1fcc7968e29dc319c5b3838
Author: Garren Smith <ga...@gmail.com>
Date: 2016-02-22T16:55:09Z
Webpack improvements
More changes to get webpack working correctly
commit fb808c33f13aa9a2fd29df69248eb9af8b4f5780
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-03-01T17:39:51Z
fix override on registry/singleton pattern
commit 6f9e32e8ca6086095af626ed97157c2840de5235
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-03-01T18:24:22Z
fix race condition, make code testable
- the code tested an async event, but the test was syncronous
- had to refactor the code a little bit to make it actually
testable
commit dadf96b991d9f439bfcd4083c95a450325e4362f
Author: Ben Keen <be...@gmail.com>
Date: 2016-03-02T17:55:27Z
zeroclipboard test update
commit 5adac0d09d62b99534e86fa3cc7ebb2500a9269c
Author: Garren Smith <ga...@gmail.com>
Date: 2016-03-10T06:49:05Z
update to latest mocha and mocha-phantomjs
Update to latest mocha-phantomjs (v4.0.2) and fix failing tests
commit 5e984f0763192173877bec4caed46890e3911ba4
Author: Ben Keen <be...@gmail.com>
Date: 2016-03-15T18:27:36Z
converting notifications to React
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-220005442
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/668
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-196971744
The license has been added to Couch here: https://github.com/apache/couchdb/pull/392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203980010
I'm on chrome. It always looked jagged.
On Thu, Mar 31, 2016 at 4:33 PM, Benjamin Keen <no...@github.com>
wrote:
> @garrensmith <https://github.com/garrensmith> - worrying about the
> animation looking jagged. Did it always look jagged for you, or just now
> and then? You're on Chrome/FF, I guess.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203966945>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203903107
This looks really cool, so awesome to see another piece of backbone disappear. Two things
* The animation looks a little jagged when a notification appears.
* The one test is failing - I think its worth just restarting the tests to see if its a flaky test.
Otherwise +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/668
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/668#discussion_r58063745
--- Diff: app/templates.js ---
@@ -0,0 +1,623 @@
+this["JST"] = this["JST"] || {};
--- End diff --
Ah ok, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/668#discussion_r58041150
--- Diff: app/templates.js ---
@@ -0,0 +1,623 @@
+this["JST"] = this["JST"] || {};
--- End diff --
This file shouldn't be here. you will have to do a `git rm`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203966945
@garrensmith - worrying about the animation looking jagged. Did it always look jagged for you, or just now and then? You're on Chrome/FF, I guess.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Notifications update
Posted by benkeen <gi...@git.apache.org>.
GitHub user benkeen reopened a pull request:
https://github.com/apache/couchdb-fauxton/pull/668
Notifications update
This updates the global notifications to use the same store as the notification panel, drop Backbone.
I chose to build it on Garren's Webpack branch: https://github.com/apache/couchdb-fauxton/pull/641 because I needed to include Velocity-React and it would have been a hack getting it into our current master, due to some fussy dependencies. Now it's just a simple matter of including it in the package.json file.
Once webpack has landed, I'll smooth out this PR so it only includes the notification change commit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton notifications-update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/668.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #668
----
commit a185ce8c866b10be8a99c9c22f090a8f9490cddc
Author: Ben Keen <be...@gmail.com>
Date: 2016-03-30T21:35:50Z
Notifications Update
This updates the global notifications to use the same store
as the notification panel and drop Backbone.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---