You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/03/15 22:06:35 UTC
Review Request 57665: Renamed a constant.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57665/
-----------------------------------------------------------
Review request for mesos, Jan Schlicht and Vinod Kone.
Bugs: MESOS-6998
https://issues.apache.org/jira/browse/MESOS-6998
Repository: mesos
Description
-------
Renamed the constant containing the default basic HTTP
authenticator's name to accommodate the addition of the
default JWT authenticator.
Diffs
-----
src/common/http.hpp a3cfc5d8f0b2e453d5f6c3e485e92dbd643737a3
src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf
src/master/flags.cpp d25cfdd00346d314c2255035e01b4a61275b0ab2
src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1
Diff: https://reviews.apache.org/r/57665/diff/1/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 57665: Renamed a constant.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57665/
-----------------------------------------------------------
(Updated March 16, 2017, 7 p.m.)
Review request for mesos, Jan Schlicht and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-6998
https://issues.apache.org/jira/browse/MESOS-6998
Repository: mesos
Description
-------
Renamed the constant containing the default basic HTTP
authenticator's name to accommodate the addition of the
default JWT authenticator.
Diffs (updated)
-----
src/common/http.hpp a3cfc5d8f0b2e453d5f6c3e485e92dbd643737a3
src/common/http.cpp ce32ff36ee58b19f2cb11d80e69ab1ff007e75ef
src/master/flags.cpp d25cfdd00346d314c2255035e01b4a61275b0ab2
src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1
Diff: https://reviews.apache.org/r/57665/diff/2/
Changes: https://reviews.apache.org/r/57665/diff/1-2/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 57665: Renamed a constant.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57665/#review169138
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 15, 2017, 10:06 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57665/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 10:06 p.m.)
>
>
> Review request for mesos, Jan Schlicht and Vinod Kone.
>
>
> Bugs: MESOS-6998
> https://issues.apache.org/jira/browse/MESOS-6998
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed the constant containing the default basic HTTP
> authenticator's name to accommodate the addition of the
> default JWT authenticator.
>
>
> Diffs
> -----
>
> src/common/http.hpp a3cfc5d8f0b2e453d5f6c3e485e92dbd643737a3
> src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf
> src/master/flags.cpp d25cfdd00346d314c2255035e01b4a61275b0ab2
> src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1
>
>
> Diff: https://reviews.apache.org/r/57665/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>