You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mark Phippard <ma...@gmail.com> on 2022/03/31 15:47:42 UTC

Impediments to release

We are getting closer to Saturday when I intended to roll the releases.

There are a couple of impediments that may need to delay the release.
Looking for feedback:

1. I posted about the PGP KEYS file. Looking for guidance on how to
proceed. I think manually sending me a file to use could be an easy
workaround?

2. STATUS of 1.10.x and 1.14.x:

This is what is left in 1.14:

Candidate changes:
==================

 * r1877310
   Add a test for issue #4711 "invalid xml file produced by svn log --xml
   --verbose --use-merge-history --search".
   Justification:
     Increase test coverage.
   Votes:
     +0: danielsh (with appropriate Skip()/XFail() annotations if needed)
     +1: hartmannathan


 * r1878379, r1883719, r1883722, r1884610
   Distinguish configure scripts on release mode and non release mode.
   Justification:
     Building process should not be prevented by swig installed in users'
     environment when users use release tar balls.
   Votes:
     +1: futatuki, stsp

 * r1890223, r1890668, r1890673
   Support building on Win64/ARM64.
   Justification:
     At user request (via SharpSvn)
   votes:
     +1: rhuijben

 * r1884474
   Fixes authz tests on Windows
   Justification:
     Should have been part of the r1883838 group that was backported
   votes:
     +1: markphip, jun66j5


The last item is also in 1.10.x. 2 tests fail on Windows without this
change. Should we hold the release for a backport of this or any of
the other proposed changes?

Thanks

Mark

Re: Impediments to release

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Nathan Hartman wrote on Thu, Mar 31, 2022 at 14:49:36 -0400:
> In fact, the last couple of days, I have sifted through hundreds and
> hundreds of changes (basically the list of merge-eligible changes from
> trunk -- a LOT of work was committed in the past 14 months!!)

That sounds very much like what we'll need to do anyway when the time
comes to write changelog for 1.15.0-rc1.

Incidentally, that's a task we used to split.  See, e.g.,
https://svn.red-bean.com/repos/manyhands/ and
https://cwiki.apache.org/confluence/display/SVN/Svn18Changes

Cheers,

Daniel

> and
> found at least a dozen or so that I've flagged to look more closely
> into, but I've decided to wait until after the release to do so. I've
> nominated only the really really low risk ones (which have been
> merged).
> 
> Cheers,
> Nathan

Re: Impediments to release

Posted by Nathan Hartman <ha...@gmail.com>.
On Thu, Mar 31, 2022 at 2:52 PM Mark Phippard <ma...@gmail.com> wrote:
>
> On Thu, Mar 31, 2022 at 2:49 PM Nathan Hartman <ha...@gmail.com> wrote:
> > There's nothing that says we have to merge everything in STATUS right
> > now. If we get the votes approving the remaining items, that's great,
> > but if not, then it may get into the next release cycle.
>
> I agree. I also do not have to roll the release this weekend and so I
> just wanted to gauge opinion. Especially if people do not want to +1
> the Windows release with test failures.

I was under the impression that the Windows test failures were fixed
by the backports already merged, but if not, then it's a good idea to
keep nudging to get the right backports. I'll keep doing everything I
can to help...

Cheers,
Nathan

Re: Impediments to release

Posted by Mark Phippard <ma...@gmail.com>.
On Thu, Mar 31, 2022 at 2:49 PM Nathan Hartman <ha...@gmail.com> wrote:
> There's nothing that says we have to merge everything in STATUS right
> now. If we get the votes approving the remaining items, that's great,
> but if not, then it may get into the next release cycle.

I agree. I also do not have to roll the release this weekend and so I
just wanted to gauge opinion. Especially if people do not want to +1
the Windows release with test failures.

Mark

Re: Impediments to release

Posted by Nathan Hartman <ha...@gmail.com>.
On Thu, Mar 31, 2022 at 1:04 PM Daniel Sahlberg
<da...@gmail.com> wrote:
>
> Den tors 31 mars 2022 kl 17:48 skrev Mark Phippard <ma...@gmail.com>:
>>
>> We are getting closer to Saturday when I intended to roll the releases.
>>
>> There are a couple of impediments that may need to delay the release.
>> Looking for feedback:
>>
>> 1. I posted about the PGP KEYS file. Looking for guidance on how to
>> proceed. I think manually sending me a file to use could be an easy
>> workaround?

Later this evening I will study this KEYS business... I'll let you
know afterwards.

>> 2. STATUS of 1.10.x and 1.14.x:
>>
>> This is what is left in 1.14:
>>
>> Candidate changes:
>> ==================

There's nothing that says we have to merge everything in STATUS right
now. If we get the votes approving the remaining items, that's great,
but if not, then it may get into the next release cycle.

In fact, the last couple of days, I have sifted through hundreds and
hundreds of changes (basically the list of merge-eligible changes from
trunk -- a LOT of work was committed in the past 14 months!!) and
found at least a dozen or so that I've flagged to look more closely
into, but I've decided to wait until after the release to do so. I've
nominated only the really really low risk ones (which have been
merged).

Cheers,
Nathan

Re: Impediments to release

Posted by Daniel Sahlberg <da...@gmail.com>.
Den tors 31 mars 2022 kl 17:48 skrev Mark Phippard <ma...@gmail.com>:

> We are getting closer to Saturday when I intended to roll the releases.
>
> There are a couple of impediments that may need to delay the release.
> Looking for feedback:
>
> 1. I posted about the PGP KEYS file. Looking for guidance on how to
> proceed. I think manually sending me a file to use could be an easy
> workaround?
>
> 2. STATUS of 1.10.x and 1.14.x:
>
> This is what is left in 1.14:
>
> Candidate changes:
> ==================
>
>  * r1877310
>    Add a test for issue #4711 "invalid xml file produced by svn log --xml
>    --verbose --use-merge-history --search".
>    Justification:
>      Increase test coverage.
>    Votes:
>      +0: danielsh (with appropriate Skip()/XFail() annotations if needed)
>      +1: hartmannathan
>

Test case. I've been working on solving the issue, and I have an updated
test case on the way in. I'd say we ignore it and when I commit a fix for
#4711 we nominate that one (including the updated test case).

 * r1878379, r1883719, r1883722, r1884610
>    Distinguish configure scripts on release mode and non release mode.
>    Justification:
>      Building process should not be prevented by swig installed in users'
>      environment when users use release tar balls.
>    Votes:
>      +1: futatuki, stsp
>

I appreciate the idea but it is a fairly complex change with a lot of
things going on in the build scripts. I'd suggest to ignore it for now and
try to merge it after 1.14.2 is released. Then we have more time to manage
regression.

 * r1890223, r1890668, r1890673
>    Support building on Win64/ARM64.
>    Justification:
>      At user request (via SharpSvn)
>    votes:
>      +1: rhuijben
>

I'm not sure how to test this, not having an ARM64 box. Looks good,
probably only affects Windows builds (and most everything #ifdef:ed to
ARM64). +0 from me.


>
>  * r1884474
>    Fixes authz tests on Windows
>    Justification:
>      Should have been part of the r1883838 group that was backported
>    votes:
>      +1: markphip, jun66j5
>

I (still) have not been able to get my Windows build rig up and running and
thus I havn't tested it. The code looks quite quite harmless, so +0
(without testing) from me. In my opinion it isn't even in core code so I
think it could be merged by just two votes.

Kind regards,
Daniel