[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2678: [GOBBLIN-807] TimingEvent is now closeable, extends GobblinEventBuilder

[GitBox <gi...@apache.org>]

zxcware commented on a change in pull request #2678: [GOBBLIN-807] TimingEvent is now closeable, extends GobblinEventBuilder
URL: https://github.com/apache/incubator-gobblin/pull/2678#discussion_r297749876
 
 

 ##########
 File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/TimingEvent.java
 ##########
 @@ -109,21 +122,75 @@ public void stop() {
    *
    * @param additionalMetadata a {@link Map} of additional metadata that should be submitted along with this event
    */
+  @Deprecated
 
 Review comment:
   Add alternative way, the same applied to `stop()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services