Mock Sling Http Servlet Response Writer does not check if already closed

[Andreas Schaefer <sc...@me.com.INVALID>]

Hi

I wanted to add a test to the GraphQLServlet to make sure that the closure of the Writer is causing a test failure but the Response Content Support does not support that. 

So I wanted to suggest a flag on the  Mock Sling Http Servlet Response that would allow to use the same Delete Print Writer that is used in the Sling Http Servlet Response Impl. This was it would not make tests fails that does not care about it but allows a tester to make sure a writer is not accidentally closed.

Any objects?

- Andy

RE: Mock Sling Http Servlet Response Writer does not check if already closed

[Stefan Seifert <St...@diva-e.com.INVALID>]

hello andy.

can you come up with a ticket & PR for this?
not sure if we really need to introduce a new flag for this.

stefan

>-----Original Message-----
>From: Andreas Schaefer <sc...@me.com.INVALID>
>Sent: Monday, July 18, 2022 8:27 PM
>To: dev <de...@sling.apache.org>
>Subject: Mock Sling Http Servlet Response Writer does not check if already
>closed
>
>Hi
>
>I wanted to add a test to the GraphQLServlet to make sure that the closure
>of the Writer is causing a test failure but the Response Content Support
>does not support that.
>
>So I wanted to suggest a flag on the  Mock Sling Http Servlet Response that
>would allow to use the same Delete Print Writer that is used in the Sling
>Http Servlet Response Impl. This was it would not make tests fails that
>does not care about it but allows a tester to make sure a writer is not
>accidentally closed.
>
>Any objects?
>
>- Andy