You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/29 11:40:51 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request, #19106: [fix][ci][branch-2.11] Fix shell license issue 1
Technoboy- opened a new pull request, #19106:
URL: https://github.com/apache/pulsar/pull/19106
### Motivation
Fix pulsar shell license issue.
### Modification
- Move `distribution/server/licenses` to `distribution/licenses`.
- Modify `server` and `shell` license to reference the parent path.
- Modify `check-binary-license.sh` filter `pulsar-client`/`pulsar-common`/`pulsar-websocket` jars.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19106: [fix][ci][branch-2.11] Fix shell license issue
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #19106:
URL: https://github.com/apache/pulsar/pull/19106#discussion_r1059225721
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -620,10 +620,14 @@ jobs:
run: |
# build docker image
# include building of Pulsar SQL, Connectors, Offloaders and server distros
- mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,tests/docker-images/latest-version-image install \
+ mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,distribution/shell,tests/docker-images/latest-version-image install \
-Pmain,docker -Dmaven.test.skip=true -Ddockerfile.build.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz && src/check-binary-license.sh ./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
Review Comment:
Put a `*` on the path will match offloader and io, offloader and io are `nar`, license check with `nar` has to do more different things, we can separate this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19106: [fix][ci][branch-2.11] Fix shell license issue
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on code in PR #19106:
URL: https://github.com/apache/pulsar/pull/19106#discussion_r1059214960
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -620,10 +620,14 @@ jobs:
run: |
# build docker image
# include building of Pulsar SQL, Connectors, Offloaders and server distros
- mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,tests/docker-images/latest-version-image install \
+ mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,distribution/shell,tests/docker-images/latest-version-image install \
-Pmain,docker -Dmaven.test.skip=true -Ddockerfile.build.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz && src/check-binary-license.sh ./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
Review Comment:
Ah, sorry I ignored it. can we give the path a `*`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #19106: [fix][ci][branch-2.11] Fix shell license issue
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #19106:
URL: https://github.com/apache/pulsar/pull/19106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19106: [fix][ci][branch-2.11] Fix shell license issue
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on code in PR #19106:
URL: https://github.com/apache/pulsar/pull/19106#discussion_r1059212023
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -620,10 +620,14 @@ jobs:
run: |
# build docker image
# include building of Pulsar SQL, Connectors, Offloaders and server distros
- mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,tests/docker-images/latest-version-image install \
+ mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,distribution/shell,tests/docker-images/latest-version-image install \
-Pmain,docker -Dmaven.test.skip=true -Ddockerfile.build.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz && src/check-binary-license.sh ./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
Review Comment:
`apache-pulsar-*-bin.tar.gz ` why * can't match `apache-pulsar-shell-*-bin.tar.gz`
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -620,10 +620,14 @@ jobs:
run: |
# build docker image
# include building of Pulsar SQL, Connectors, Offloaders and server distros
- mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,tests/docker-images/latest-version-image install \
+ mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,distribution/shell,tests/docker-images/latest-version-image install \
-Pmain,docker -Dmaven.test.skip=true -Ddockerfile.build.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz && src/check-binary-license.sh ./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
Review Comment:
`apache-pulsar-*-bin.tar.gz ` why `*` can't match `apache-pulsar-shell-*-bin.tar.gz`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19106: [fix][ci][branch-2.11] Fix shell license issue
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #19106:
URL: https://github.com/apache/pulsar/pull/19106#discussion_r1059213998
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -620,10 +620,14 @@ jobs:
run: |
# build docker image
# include building of Pulsar SQL, Connectors, Offloaders and server distros
- mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,tests/docker-images/latest-version-image install \
+ mvn -B -am -pl pulsar-sql/presto-distribution,distribution/io,distribution/offloaders,distribution/server,distribution/shell,tests/docker-images/latest-version-image install \
-Pmain,docker -Dmaven.test.skip=true -Ddockerfile.build.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz && src/check-binary-license.sh ./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
Review Comment:
Oh, I think it can match, but only in a different path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #19106: [fix][ci] Fix shell license issue
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #19106: [fix][ci] Fix shell license issue
URL: https://github.com/apache/pulsar/pull/19106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org