You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/03/21 00:05:04 UTC
Review Request 66189: ATLAS-2491: updated Hive hook to use V2
notifications
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66189/
-----------------------------------------------------------
Review request for atlas and Ramesh Mani.
Bugs: ATLAS-2491
https://issues.apache.org/jira/browse/ATLAS-2491
Repository: atlas
Description
-------
This is a backport of following Hive hook enhancements committed in master via ATLAS-2491.
- updated Hive hook implementation to replace use of V1 notifications with V2 equivalents
- updated import-hive to replace use of V1 APIs with V2 equivalents
- fixed UT, IT failures
Diffs
-----
addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 721292179
addons/hive-bridge/pom.xml 88763513e
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java 663fcdcdc
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 6016f6dc7
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 21b769693
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterDatabase.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTable.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRenameCol.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropDatabase.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropTable.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/ASTRewriter.java 3a2506bdb
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/HiveASTRewriter.java 4cd219f3f
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/LiteralRewriter.java 789b98123
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteContext.java 505616e94
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java c87bf6ba7
addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 0d163ee9a
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveLiteralRewriterTest.java f4abfb6ab
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0256cf375
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetastoreBridgeIT.java d09db1b41
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java f7404ae14
catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java cee102af9
catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java c2a843b5b
catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java b59dcae0c
pom.xml 949167baa
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java b8d95f0db
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 4ecf086de
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java fe2c7be8f
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 718538a06
webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java d80662f55
webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 592c2a626
webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java a17362388
webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 3ee67b3a7
webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java 351e5ae77
Diff: https://reviews.apache.org/r/66189/diff/1/
Testing
-------
UTs and ITs for hive-bridge pass without any failure.
Thanks,
Madhan Neethiraj
Re: Review Request 66189: ATLAS-2491: updated Hive hook to use V2
notifications
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66189/#review199690
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On March 21, 2018, 10:04 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66189/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 10:04 a.m.)
>
>
> Review request for atlas and Ramesh Mani.
>
>
> Bugs: ATLAS-2491
> https://issues.apache.org/jira/browse/ATLAS-2491
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is a backport of following Hive hook enhancements committed in master via ATLAS-2491.
>
> - updated Hive hook implementation to replace use of V1 notifications with V2 equivalents
> - updated import-hive to replace use of V1 APIs with V2 equivalents
> - fixed UT, IT failures
>
>
> Diffs
> -----
>
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 721292179
> addons/hive-bridge/pom.xml 88763513e
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java 663fcdcdc
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 6016f6dc7
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 21b769693
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterDatabase.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTable.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRenameCol.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropDatabase.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropTable.java PRE-CREATION
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/ASTRewriter.java 3a2506bdb
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/HiveASTRewriter.java 4cd219f3f
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/LiteralRewriter.java 789b98123
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteContext.java 505616e94
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java c87bf6ba7
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 0d163ee9a
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveLiteralRewriterTest.java f4abfb6ab
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0256cf375
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetastoreBridgeIT.java d09db1b41
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java f7404ae14
> addons/sqoop-bridge/src/test/java/org/apache/atlas/sqoop/hook/SqoopHookIT.java b1bd1156f
> catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java cee102af9
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java c2a843b5b
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java b59dcae0c
> pom.xml 33b05b91f
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java b8d95f0db
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 4ecf086de
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java fe2c7be8f
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 718538a06
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java d80662f55
> webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 592c2a626
> webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java a17362388
> webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 3ee67b3a7
> webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java 351e5ae77
>
>
> Diff: https://reviews.apache.org/r/66189/diff/2/
>
>
> Testing
> -------
>
> UTs and ITs for hive-bridge pass without any failure.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 66189: ATLAS-2491: updated Hive hook to use V2
notifications
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66189/
-----------------------------------------------------------
(Updated March 21, 2018, 5:04 p.m.)
Review request for atlas and Ramesh Mani.
Changes
-------
FalconHookIT update to use a higher wait time to look for Atlas entities
Bugs: ATLAS-2491
https://issues.apache.org/jira/browse/ATLAS-2491
Repository: atlas
Description
-------
This is a backport of following Hive hook enhancements committed in master via ATLAS-2491.
- updated Hive hook implementation to replace use of V1 notifications with V2 equivalents
- updated import-hive to replace use of V1 APIs with V2 equivalents
- fixed UT, IT failures
Diffs (updated)
-----
addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 721292179
addons/hive-bridge/pom.xml 88763513e
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java 663fcdcdc
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 6016f6dc7
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 21b769693
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterDatabase.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTable.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRenameCol.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropDatabase.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropTable.java PRE-CREATION
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/ASTRewriter.java 3a2506bdb
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/HiveASTRewriter.java 4cd219f3f
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/LiteralRewriter.java 789b98123
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteContext.java 505616e94
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java c87bf6ba7
addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 0d163ee9a
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveLiteralRewriterTest.java f4abfb6ab
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 0256cf375
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetastoreBridgeIT.java d09db1b41
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java f7404ae14
addons/sqoop-bridge/src/test/java/org/apache/atlas/sqoop/hook/SqoopHookIT.java b1bd1156f
catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java cee102af9
catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java c2a843b5b
catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java b59dcae0c
pom.xml 33b05b91f
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java b8d95f0db
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 4ecf086de
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java fe2c7be8f
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 718538a06
webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java d80662f55
webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 592c2a626
webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java a17362388
webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 3ee67b3a7
webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java 351e5ae77
Diff: https://reviews.apache.org/r/66189/diff/2/
Changes: https://reviews.apache.org/r/66189/diff/1-2/
Testing
-------
UTs and ITs for hive-bridge pass without any failure.
Thanks,
Madhan Neethiraj