You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2025/07/30 18:13:24 UTC
[PR] [SPARK-53022][TESTS] Add MemoryConsumerBenchmark [spark]
zhztheplayer opened a new pull request, #51728:
URL: https://github.com/apache/spark/pull/51728
### What changes were proposed in this pull request?
Adds a `MemoryConsumerBenchmark`.
### Why are the changes needed?
We once noticed that massive off-heap memory allocation calls could slow down executions in our 3rd plugin. Adds a benchmark could help measuring the performance of the memory allocation API, and possibly help with improving performance of the memory code in the future.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
This is a patch to add a test.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53022][TESTS] Add MemoryConsumerBenchmark [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51728:
URL: https://github.com/apache/spark/pull/51728#issuecomment-3507239224
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53022][TESTS] Add MemoryConsumerBenchmark [spark]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #51728:
URL: https://github.com/apache/spark/pull/51728#issuecomment-3137384148
The current benchmark result:
```
OpenJDK 64-Bit Server VM 21.0.7+6-b1038.54 on Linux 6.14.0-24-generic
Unknown processor
On-heap allocations: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
use and free - test 0 0 0 243902.4 0.0 1.0X
use and free - user 0 0 0 30030.0 0.0 0.1X
Running benchmark: Off-heap allocations
Running case: use and free - test
Stopped after 3 iterations, 0 ms
Running case: use and free - user
Stopped after 3 iterations, 0 ms
OpenJDK 64-Bit Server VM 21.0.7+6-b1038.54 on Linux 6.14.0-24-generic
Unknown processor
Off-heap allocations: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
use and free - test 0 0 0 243902.4 0.0 1.0X
use and free - user 0 0 0 48076.9 0.0 0.2X
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53022][TESTS] Add MemoryConsumerBenchmark [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #51728: [SPARK-53022][TESTS] Add MemoryConsumerBenchmark
URL: https://github.com/apache/spark/pull/51728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org