You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "HomminLee (via GitHub)" <gi...@apache.org> on 2023/09/28 06:08:59 UTC

[GitHub] [dolphinscheduler] HomminLee opened a new pull request, #14974: cherry-pick Allow execute task in workflow instance (#13103)

HomminLee opened a new pull request, #14974:
URL: https://github.com/apache/dolphinscheduler/pull/14974

   <!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
   
   ## Purpose of the pull request
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   Allow to execute task in workflow instance.
   
   close #14805
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   (or)
   
   If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] cherry-pick Allow execute task in workflow instance (#13103) [dolphinscheduler]

Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on PR #14974:
URL: https://github.com/apache/dolphinscheduler/pull/14974#issuecomment-1754230732

   It looks like a feature, in 3.1.x version, we only fix bugs. WDYT @zhuangchong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] cherry-pick Allow execute task in workflow instance (#13103) [dolphinscheduler]

Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong commented on PR #14974:
URL: https://github.com/apache/dolphinscheduler/pull/14974#issuecomment-1754270381

   > It looks like a feature, in 3.1.x version, we only fix bugs. WDYT @zhuangchong
   
   @qingwli You are right. It is not recommended to merge feature into the 3.1.x branch, as this may cause other problems.
   
   @HomminLee Thanks for your contribution, I will close this PR.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] HomminLee commented on pull request #14974: cherry-pick Allow execute task in workflow instance (#13103)

Posted by "HomminLee (via GitHub)" <gi...@apache.org>.
HomminLee commented on PR #14974:
URL: https://github.com/apache/dolphinscheduler/pull/14974#issuecomment-1742088265

   > Is this issue fixed in dev branch?
   
   Yes, this pr is cherry pick from dev.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] cherry-pick Allow execute task in workflow instance (#13103) [dolphinscheduler]

Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong closed pull request #14974: cherry-pick Allow execute task in workflow instance (#13103) 
URL: https://github.com/apache/dolphinscheduler/pull/14974


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] qingwli commented on pull request #14974: cherry-pick Allow execute task in workflow instance (#13103)

Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on PR #14974:
URL: https://github.com/apache/dolphinscheduler/pull/14974#issuecomment-1738640948

   Is this issue fixed in dev branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org