You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Alexander Sinyushkin <Al...@svnkit.com> on 2007/02/09 17:54:04 UTC
Can not checkout revisions which author name rev property contains ASCII control characters
Hello, SVN devs! I have recently encountered the following problem:
I tried to make a dir in a repository remotely and used an ASCII
control character ('\b' in particular) in my --username switch:
>svn mkdir file:///G:/materials/rep/test2 --username Sasha
Committed revision 442.
svn.exe committed without problems.
But when I tried to checkout what I had committed I got the following
error:
>svn co http://localhost/materials/rep/test2 test5 --username garry --password garry
svn: Malformed XML: not well-formed (invalid token) at line 6
I looked at the corresponding .svn/log file, not at the 6th but at the
5th line I found my author name:
<modify-entry
committed-rev="442"
committed-date="2007-02-09T16:36:17.937500Z"
name=""
last-author="Sasha"
uuid="466bc291-b22d-3743-ba76-018ba5011628"/>
<modify-wcprop
name=""
propname="svn:wc:ra_dav:version-url"
propval="/materials/rep/!svn/ver/442/test2"/>
It seems to me that the problem is in this backspace symbol. Is it
expected behaviour that svn.exe crashes attempting to parse the log
file?
--
Alexander Sinyushkin,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Can not checkout revisions which author name rev property contains ASCII control characters
Posted by Erik Huelsmann <eh...@gmail.com>.
On 3/4/07, Malcolm Rowe <ma...@farside.org.uk> wrote:
> On Sun, Mar 04, 2007 at 04:32:28PM +0100, Erik Huelsmann wrote:
> > We have a perfectly sane way to serialize internal datastructures in
> > our codebase which won't need encodings: ra_svn uses tuples and some
> > other data types which nicely fit our in-memory storage model.
> > Shouldn't we switch to that instead of fixing our XML
> > storing/parsing?
> >
>
> Now that _would_ make sense. +1.
It's even a very simple (local) change: all log-generation and
execution is confined to libsvn_wc/log.c.
bye,
Erik.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Can not checkout revisions which author name rev property contains ASCII control characters
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Sun, Mar 04, 2007 at 04:32:28PM +0100, Erik Huelsmann wrote:
> We have a perfectly sane way to serialize internal datastructures in
> our codebase which won't need encodings: ra_svn uses tuples and some
> other data types which nicely fit our in-memory storage model.
> Shouldn't we switch to that instead of fixing our XML
> storing/parsing?
>
Now that _would_ make sense. +1.
Regards,
Malcolm
Re: Can not checkout revisions which author name rev property contains
ASCII control characters
Posted by Max Bowsher <ma...@ukf.net>.
Erik Huelsmann wrote:
> On 3/1/07, Malcolm Rowe <ma...@farside.org.uk> wrote:
>> On Fri, Feb 09, 2007 at 11:54:04PM +0600, Alexander Sinyushkin wrote:
>> > Hello, SVN devs! I have recently encountered the following problem:
>> > I tried to make a dir in a repository remotely and used an ASCII
>> > control character ('\b' in particular) in my --username switch:
>> >
>> > >svn mkdir file:///G:/materials/rep/test2 --username Sasha
>> >
>> > Committed revision 442.
>> >
>> > svn.exe committed without problems.
>> >
>> > But when I tried to checkout what I had committed I got the following
>> > error:
>> >
>> > >svn co http://localhost/materials/rep/test2 test5 --username garry
>> --password garry
>> > svn: Malformed XML: not well-formed (invalid token) at line 6
>> >
>> > It seems to me that the problem is in this backspace symbol. Is it
>> > expected behaviour that svn.exe crashes attempting to parse the log
>> > file?
>> >
>>
>> No, we should either be preventing the original commit, or (more likely)
>> encoding the string correctly when we write it to the log. I've raised
>> issue 2730 to cover this.
>
> We have a perfectly sane way to serialize internal datastructures in
> our codebase which won't need encodings: ra_svn uses tuples and some
> other data types which nicely fit our in-memory storage model.
> Shouldn't we switch to that instead of fixing our XML
> storing/parsing?
>
> Just a thought.
Ooh, that's a nice idea. IMO, there's even less reason to use XML for
WC-logs than there was for entries files.
Max.
Re: Can not checkout revisions which author name rev property contains ASCII control characters
Posted by Erik Huelsmann <eh...@gmail.com>.
On 3/1/07, Malcolm Rowe <ma...@farside.org.uk> wrote:
> On Fri, Feb 09, 2007 at 11:54:04PM +0600, Alexander Sinyushkin wrote:
> > Hello, SVN devs! I have recently encountered the following problem:
> > I tried to make a dir in a repository remotely and used an ASCII
> > control character ('\b' in particular) in my --username switch:
> >
> > >svn mkdir file:///G:/materials/rep/test2 --username Sasha
> >
> > Committed revision 442.
> >
> > svn.exe committed without problems.
> >
> > But when I tried to checkout what I had committed I got the following
> > error:
> >
> > >svn co http://localhost/materials/rep/test2 test5 --username garry --password garry
> > svn: Malformed XML: not well-formed (invalid token) at line 6
> >
> > It seems to me that the problem is in this backspace symbol. Is it
> > expected behaviour that svn.exe crashes attempting to parse the log
> > file?
> >
>
> No, we should either be preventing the original commit, or (more likely)
> encoding the string correctly when we write it to the log. I've raised
> issue 2730 to cover this.
We have a perfectly sane way to serialize internal datastructures in
our codebase which won't need encodings: ra_svn uses tuples and some
other data types which nicely fit our in-memory storage model.
Shouldn't we switch to that instead of fixing our XML
storing/parsing?
Just a thought.
Bye,
Erik.
Re: Can not checkout revisions which author name rev property contains ASCII control characters
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Fri, Feb 09, 2007 at 11:54:04PM +0600, Alexander Sinyushkin wrote:
> Hello, SVN devs! I have recently encountered the following problem:
> I tried to make a dir in a repository remotely and used an ASCII
> control character ('\b' in particular) in my --username switch:
>
> >svn mkdir file:///G:/materials/rep/test2 --username Sasha
>
> Committed revision 442.
>
> svn.exe committed without problems.
>
> But when I tried to checkout what I had committed I got the following
> error:
>
> >svn co http://localhost/materials/rep/test2 test5 --username garry --password garry
> svn: Malformed XML: not well-formed (invalid token) at line 6
>
> It seems to me that the problem is in this backspace symbol. Is it
> expected behaviour that svn.exe crashes attempting to parse the log
> file?
>
No, we should either be preventing the original commit, or (more likely)
encoding the string correctly when we write it to the log. I've raised
issue 2730 to cover this.
Regards,
Malcolm