You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by do...@hyperreal.org on 1998/11/08 02:15:20 UTC

cvs commit: modperl/src/modules/perl File.xs

dougm       98/11/07 17:15:20

  Modified:    t/net/perl file.pl
               src/modules/perl File.xs
  Log:
  turns out the C stdio tmpfile() is bloody slow, if folks want it,
  they can use IO::File
  
  Revision  Changes    Path
  1.2       +7 -7      modperl/t/net/perl/file.pl
  
  Index: file.pl
  ===================================================================
  RCS file: /export/home/cvs/modperl/t/net/perl/file.pl,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- file.pl	1998/09/26 16:07:13	1.1
  +++ file.pl	1998/11/08 01:15:19	1.2
  @@ -10,16 +10,16 @@
   }
   
   require Apache::File;
  -print "1..7\n";
  +print "1..5\n";
   my $fh = Apache::File->new;
   test ++$i, $fh;
   test ++$i, $fh->open($0);
   test ++$i, !$fh->open("$0.nochance");
   test ++$i, !Apache::File->new("$0.yeahright");
  -my $tmp = Apache::File->tmp;
  -test ++$i, $tmp;
  -++$i;
  -print $tmp "ok $i\n";
  -seek $tmp, 0, 0;
  -print scalar(<$tmp>);
  +#my $tmp = Apache::File->tmp;
  +#test ++$i, $tmp;
  +#++$i;
  +#print $tmp "ok $i\n";
  +#seek $tmp, 0, 0;
  +#print scalar(<$tmp>);
   test ++$i, Apache::File->tmpfile;
  
  
  
  1.4       +7 -10     modperl/src/modules/perl/File.xs
  
  Index: File.xs
  ===================================================================
  RCS file: /export/home/cvs/modperl/src/modules/perl/File.xs,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- File.xs	1998/10/26 20:55:03	1.3
  +++ File.xs	1998/11/08 01:15:20	1.4
  @@ -86,6 +86,9 @@
   
   PROTOTYPES: DISABLE
   
  +BOOT:
  +    items = items; /*avoid warning*/ 
  +
   void
   ApacheFile_new(class, filename=Nullsv)
       char *class
  @@ -107,6 +110,8 @@
       SV *self
       SV *filename
   
  +#if 0
  +
   void
   ApacheFile_tmp(self)
       SV *self
  @@ -122,6 +127,8 @@
       else
           XPUSHs(RETVAL);
   
  +#endif
  +
   bool
   ApacheFile_close(self)
       SV *self
  @@ -200,13 +207,3 @@
   ap_discard_request_body(r)
       Apache r
   
  -FILE *
  -ap_fopen(r, name, mode="r")
  -    Apache r
  -    const char *name
  -    const char *mode
  -
  -int
  -ap_fclose(r, fd)
  -    Apache r
  -    FILE *fd