You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/10 14:50:04 UTC

[GitHub] [skywalking] codecov-io commented on issue #4039: Fix NPE when worker not found, mostly new OAL metrics added

codecov-io commented on issue #4039: Fix NPE when worker not found, mostly new OAL metrics added
URL: https://github.com/apache/skywalking/pull/4039#issuecomment-564067488
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4039?src=pr&el=h1) Report
   > Merging [#4039](https://codecov.io/gh/apache/skywalking/pull/4039?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/3f2f75a6663b885104488bc9d9e096866e04ab34?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4039/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4039?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4039      +/-   ##
   ==========================================
   + Coverage   26.96%   26.96%   +<.01%     
   ==========================================
     Files        1128     1128              
     Lines       24872    24873       +1     
     Branches     3587     3587              
   ==========================================
   + Hits         6707     6708       +1     
     Misses      17568    17568              
     Partials      597      597
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4039?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...g/oap/server/core/remote/RemoteServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/4039/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL1JlbW90ZVNlcnZpY2VIYW5kbGVyLmphdmE=) | `79.54% <75%> (+0.47%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4039?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4039?src=pr&el=footer). Last update [3f2f75a...5841a5f](https://codecov.io/gh/apache/skywalking/pull/4039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services