You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "klesh (via GitHub)" <gi...@apache.org> on 2023/07/20 00:49:06 UTC
[GitHub] [incubator-devlake] klesh opened a new pull request, #5705: fix: connection id should be int
klesh opened a new pull request, #5705:
URL: https://github.com/apache/incubator-devlake/pull/5705
### Summary
fix a typo for #5701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #5705: fix: connection id should be int
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #5705:
URL: https://github.com/apache/incubator-devlake/pull/5705#discussion_r1268952224
##########
backend/server/services/remote/models/models.go:
##########
@@ -140,7 +140,7 @@ type PipelineData struct {
type ToolModel struct {
common.NoPKModel
- ConnectionId string `json:"connectionId" gorm:"column:connection_id;not null"`
+ ConnectionId int `json:"connectionId" gorm:"column:connection_id;not null"`
Review Comment:
done, but it seems like they are yielding the same data type `int8` on pg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #5705: fix: connection id should be int
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on code in PR #5705:
URL: https://github.com/apache/incubator-devlake/pull/5705#discussion_r1268838505
##########
backend/server/services/remote/models/models.go:
##########
@@ -140,7 +140,7 @@ type PipelineData struct {
type ToolModel struct {
common.NoPKModel
- ConnectionId string `json:"connectionId" gorm:"column:connection_id;not null"`
+ ConnectionId int `json:"connectionId" gorm:"column:connection_id;not null"`
Review Comment:
I think it's better if we made it uint64 so it's like our other models
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 merged pull request #5705: fix: connection id should be uint64
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 merged PR #5705:
URL: https://github.com/apache/incubator-devlake/pull/5705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org