You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Ryan McKinley <ry...@gmail.com> on 2008/07/16 02:41:28 UTC

spellcheck component vs handler

looking over some of the spellchecking stuff...

One thing that sticks out as strange is that the component and the  
handler have different params!

The handler uses:
  sp.query.accuracy
  sp.query.onlyMorePopular
  ...
   http://wiki.apache.org/solr/SpellCheckerRequestHandler

while the component uses:
  spellcheck.onlyMorePopular
  spellcheck.extendedResults
  ...

   http://wiki.apache.org/solr/SpellCheckComponent

This seems a little weird to me...

the Spellchecker was around in 1.2, but in a much simpler form:
http://svn.apache.org/repos/asf/lucene/solr/tags/release-1.2.0/src/java/org/apache/solr/handler/SpellCheckerRequestHandler.java

What is the plan for the Handler?  it seems to duplicate much of what  
happens in the component.  Should it be deprecated?  Should it be  
reverted to the 1.2 version -- keeping all the new functionality in  
the component rather then the handler?

Can/should the SpellCheckerRequestHandler be implemented using the  
SearchComponent?

thoughts?
ryan







Re: spellcheck component vs handler

Posted by Grant Ingersoll <gs...@apache.org>.
https://issues.apache.org/jira/browse/SOLR-485


On Jul 16, 2008, at 7:23 AM, Shalin Shekhar Mangar wrote:

> The plan was to deprecate the SpellCheckRequestHandler and replace  
> it with
> the component. Since it was a new component, new parameter names  
> were used
> (which IMO look better)
>
> On Wed, Jul 16, 2008 at 6:11 AM, Ryan McKinley <ry...@gmail.com>  
> wrote:
>
>> looking over some of the spellchecking stuff...
>>
>> One thing that sticks out as strange is that the component and the  
>> handler
>> have different params!
>>
>> The handler uses:
>> sp.query.accuracy
>> sp.query.onlyMorePopular
>> ...
>> http://wiki.apache.org/solr/SpellCheckerRequestHandler
>>
>> while the component uses:
>> spellcheck.onlyMorePopular
>> spellcheck.extendedResults
>> ...
>>
>> http://wiki.apache.org/solr/SpellCheckComponent
>>
>> This seems a little weird to me...
>>
>> the Spellchecker was around in 1.2, but in a much simpler form:
>>
>> http://svn.apache.org/repos/asf/lucene/solr/tags/release-1.2.0/src/java/org/apache/solr/handler/SpellCheckerRequestHandler.java
>>
>> What is the plan for the Handler?  it seems to duplicate much of what
>> happens in the component.  Should it be deprecated?  Should it be  
>> reverted
>> to the 1.2 version -- keeping all the new functionality in the  
>> component
>> rather then the handler?
>>
>> Can/should the SpellCheckerRequestHandler be implemented using the
>> SearchComponent?
>>
>> thoughts?
>> ryan
>>
>>
>>
>>
>>
>>
>>
>
>
> -- 
> Regards,
> Shalin Shekhar Mangar.

--------------------------
Grant Ingersoll
http://www.lucidimagination.com

Lucene Helpful Hints:
http://wiki.apache.org/lucene-java/BasicsOfPerformance
http://wiki.apache.org/lucene-java/LuceneFAQ








Re: spellcheck component vs handler

Posted by Shalin Shekhar Mangar <sh...@gmail.com>.
The plan was to deprecate the SpellCheckRequestHandler and replace it with
the component. Since it was a new component, new parameter names were used
(which IMO look better)

On Wed, Jul 16, 2008 at 6:11 AM, Ryan McKinley <ry...@gmail.com> wrote:

> looking over some of the spellchecking stuff...
>
> One thing that sticks out as strange is that the component and the handler
> have different params!
>
> The handler uses:
>  sp.query.accuracy
>  sp.query.onlyMorePopular
>  ...
>  http://wiki.apache.org/solr/SpellCheckerRequestHandler
>
> while the component uses:
>  spellcheck.onlyMorePopular
>  spellcheck.extendedResults
>  ...
>
>  http://wiki.apache.org/solr/SpellCheckComponent
>
> This seems a little weird to me...
>
> the Spellchecker was around in 1.2, but in a much simpler form:
>
> http://svn.apache.org/repos/asf/lucene/solr/tags/release-1.2.0/src/java/org/apache/solr/handler/SpellCheckerRequestHandler.java
>
> What is the plan for the Handler?  it seems to duplicate much of what
> happens in the component.  Should it be deprecated?  Should it be reverted
> to the 1.2 version -- keeping all the new functionality in the component
> rather then the handler?
>
> Can/should the SpellCheckerRequestHandler be implemented using the
> SearchComponent?
>
> thoughts?
> ryan
>
>
>
>
>
>
>


-- 
Regards,
Shalin Shekhar Mangar.