You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Balázs Donát Bessenyei <be...@cloudera.com> on 2016/08/02 18:20:20 UTC
Re: Review Request 34200: Review request for FLUME-2689,
reloading conf file leads syslogTcpSource not receives any event
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34200/#review144520
-----------------------------------------------------------
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java (lines 136 - 140)
<https://reviews.apache.org/r/34200/#comment210528>
Can we maybe use an approach like this: https://github.com/apache/flume/blob/c8c0f9b8404ef60222f49aa91f74f5a846b57ca7/flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java#L220 to avoid having that long pause?
- Bal�zs Don�t Bessenyei
On July 27, 2016, 2:19 a.m., wei yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34200/
> -----------------------------------------------------------
>
> (Updated July 27, 2016, 2:19 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2689
> https://issues.apache.org/jira/browse/FLUME-2689
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Reloading conf file will stop old syslog source and start new syslog source. Stopping syslog tcp source only closes the NioServerSocketChannel, resulting in the client sends data through the old channel. In that case, the new source never receives data. The tcpdump shows the events have received but the new source doesn't and ss shows the client connection stays same with old one.
> The right way to stop syslog source is close both the NioSocketChannel and NioServerSocketChannel, and shutdown the executor.
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 185c00c
> flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java 10ef8d8
>
> Diff: https://reviews.apache.org/r/34200/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> wei yang
>
>