[jira] [Comment Edited] (KAFKA-6579) Consolidate window store and session store unit tests into a single class

["Ahmed Sobeh (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635340#comment-17635340 ] 

Ahmed Sobeh edited comment on KAFKA-6579 at 11/17/22 12:44 PM:
---------------------------------------------------------------

will give this a shot if it's ok [~teamurko] 


was (Author: JIRAUSER295920):
will give this a shoft if it's ok [~teamurko] 

> Consolidate window store and session store unit tests into a single class
> -------------------------------------------------------------------------
>
>                 Key: KAFKA-6579
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6579
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Priority: Major
>              Labels: newbie, unit-test
>
> For key value store, we have a {{AbstractKeyValueStoreTest}} that is shared among all its implementations; however for window and session stores, each class has its own independent unit test classes that do not share the test coverage. In fact, many of these test classes share the same unit test functions (e.g. {{RocksDBWindowStoreTest}}, {{CompositeReadOnlyWindowStoreTest}} and {{CachingWindowStoreTest}}).
> It is better to use the same pattern as for key value stores to consolidate these test functions into a shared base class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)