You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/10/13 22:54:35 UTC

[kudu-CR] [tablet] a small clean up on 'disable compaction'

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20577


Change subject: [tablet] a small clean up on 'disable_compaction'
......................................................................

[tablet] a small clean up on 'disable_compaction'

While changing the code in the Tablet class, I found the naming of the
methods related to the 'disable_compaction' property (a) confusing and
(b) non-compliant with the project's style guide.

This patch addresses the issue.  I also extended the test coverage
for the related functionality a little bit.

Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
---
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_mm_ops.h
6 files changed, 56 insertions(+), 42 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/20577/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
Gerrit-Change-Number: 20577
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [tablet] a small clean up on 'disable compaction'

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20577 )

Change subject: [tablet] a small clean up on 'disable_compaction'
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
Gerrit-Change-Number: 20577
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 16 Oct 2023 03:22:08 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet] a small clean up on 'disable compaction'

Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20577 )

Change subject: [tablet] a small clean up on 'disable_compaction'
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
Gerrit-Change-Number: 20577
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Oct 2023 01:57:53 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet] a small clean up on 'disable compaction'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20577 )

Change subject: [tablet] a small clean up on 'disable_compaction'
......................................................................

[tablet] a small clean up on 'disable_compaction'

While changing the code in the Tablet class, I found the naming of the
methods related to the 'disable_compaction' property (a) confusing and
(b) non-compliant with the project's style guide.

This patch addresses the issue.  I also extended the test coverage
for the related functionality a little bit.

Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
Reviewed-on: http://gerrit.cloudera.org:8080/20577
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: KeDeng <kd...@gmail.com>
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_mm_ops.h
6 files changed, 56 insertions(+), 42 deletions(-)

Approvals:
  Alexey Serbin: Verified
  KeDeng: Looks good to me, but someone else must approve
  Yifan Zhang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/20577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
Gerrit-Change-Number: 20577
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [tablet] a small clean up on 'disable compaction'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20577 )

Change subject: [tablet] a small clean up on 'disable_compaction'
......................................................................


Patch Set 2: Verified+1

unrelated test failures in CatalogManagerTskITest.LeadershipChangeOnTskGeneration


-- 
To view, visit http://gerrit.cloudera.org:8080/20577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
Gerrit-Change-Number: 20577
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 14 Oct 2023 06:14:41 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet] a small clean up on 'disable compaction'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, KeDeng, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20577

to look at the new patch set (#2).

Change subject: [tablet] a small clean up on 'disable_compaction'
......................................................................

[tablet] a small clean up on 'disable_compaction'

While changing the code in the Tablet class, I found the naming of the
methods related to the 'disable_compaction' property (a) confusing and
(b) non-compliant with the project's style guide.

This patch addresses the issue.  I also extended the test coverage
for the related functionality a little bit.

Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
---
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_mm_ops.h
6 files changed, 56 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/20577/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
Gerrit-Change-Number: 20577
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tablet] a small clean up on 'disable compaction'

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [tablet] a small clean up on 'disable_compaction'
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/20577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I209a58505ea655a94563c51ba00b86ee24ea3e40
Gerrit-Change-Number: 20577
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)