You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/07/13 02:41:38 UTC
[kudu-CR] [docker] Use ccache and Gradle cache across builds
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16181
Change subject: [docker] Use ccache and Gradle cache across builds
......................................................................
[docker] Use ccache and Gradle cache across builds
This patch uses buildkits `--mount=type=cache` syntax to allow
the builds ccache and Gradle cache to be used across Docker builds.
This speeds up the Docker build when re-building the thirdparty,
C++, and Java modules and mirrors the best practices for
non-Docker based builds.
See the buildkit documentation for details:
https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/experimental.md#run---mounttypecache
Below shows the runtime difference for subsequent builds of the
thirdparty target and Kudu target before and after this change:
`thirdparty` target:
- Before: 1:18:13
- After: 0:17:47
`kudu` target:
- Before: 0:19:10
- After: 0:04:08
Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
---
M docker/Dockerfile
M docker/README.adoc
M docker/bootstrap-dev-env.sh
3 files changed, 40 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/16181/1
--
To view, visit http://gerrit.cloudera.org:8080/16181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Gerrit-Change-Number: 16181
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docker] Use ccache and Gradle cache across builds
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16181
to look at the new patch set (#2).
Change subject: [docker] Use ccache and Gradle cache across builds
......................................................................
[docker] Use ccache and Gradle cache across builds
This patch uses buildkits `--mount=type=cache` syntax to allow
the builds ccache and Gradle cache to be used across Docker builds.
This speeds up the Docker build when re-building the thirdparty,
C++, and Java modules and mirrors the best practices for
non-Docker based builds.
See the buildkit documentation for details:
https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/experimental.md#run---mounttypecache
Below shows the runtime difference for subsequent builds of the
thirdparty target and Kudu target before and after this change:
`thirdparty` target:
- Before: 1:18:13
- After: 0:17:47
`kudu` target:
- Before: 0:19:10
- After: 0:04:08
Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
---
M docker/Dockerfile
M docker/README.adoc
M docker/docker-build.py
3 files changed, 40 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/16181/2
--
To view, visit http://gerrit.cloudera.org:8080/16181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Gerrit-Change-Number: 16181
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Use ccache and Gradle cache across builds
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16181 )
Change subject: [docker] Use ccache and Gradle cache across builds
......................................................................
[docker] Use ccache and Gradle cache across builds
This patch uses buildkits `--mount=type=cache` syntax to allow
the builds ccache and Gradle cache to be used across Docker builds.
This speeds up the Docker build when re-building the thirdparty,
C++, and Java modules and mirrors the best practices for
non-Docker based builds.
See the buildkit documentation for details:
https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/experimental.md#run---mounttypecache
Below shows the runtime difference for subsequent builds of the
thirdparty target and Kudu target before and after this change:
`thirdparty` target:
- Before: 1:18:13
- After: 0:17:47
`kudu` target:
- Before: 0:19:10
- After: 0:04:08
Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Reviewed-on: http://gerrit.cloudera.org:8080/16181
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Greg Solovyev <gs...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M docker/Dockerfile
M docker/README.adoc
M docker/docker-build.py
3 files changed, 40 insertions(+), 13 deletions(-)
Approvals:
Kudu Jenkins: Verified
Bankim Bhavsar: Looks good to me, but someone else must approve
Greg Solovyev: Looks good to me, but someone else must approve
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Gerrit-Change-Number: 16181
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Use ccache and Gradle cache across builds
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16181 )
Change subject: [docker] Use ccache and Gradle cache across builds
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16181/1/docker/Dockerfile
File docker/Dockerfile:
http://gerrit.cloudera.org:8080/#/c/16181/1/docker/Dockerfile@464
PS1, Line 464: ENV UID=1001
: ENV GID=1001
> Different 1001 uid/gid here for Impala?
Yeah, given it's a different user/group it should be a different id.
http://gerrit.cloudera.org:8080/#/c/16181/1/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/16181/1/docker/bootstrap-dev-env.sh@107
PS1, Line 107: rm -f $DTLS_RPM
> that variable no longer exist
Done
--
To view, visit http://gerrit.cloudera.org:8080/16181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Gerrit-Change-Number: 16181
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Jul 2020 20:48:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Use ccache and Gradle cache across builds
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16181 )
Change subject: [docker] Use ccache and Gradle cache across builds
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Gerrit-Change-Number: 16181
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 16 Jul 2020 13:03:55 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Use ccache and Gradle cache across builds
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16181 )
Change subject: [docker] Use ccache and Gradle cache across builds
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Gerrit-Change-Number: 16181
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Jul 2020 21:17:21 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Use ccache and Gradle cache across builds
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16181 )
Change subject: [docker] Use ccache and Gradle cache across builds
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Gerrit-Change-Number: 16181
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Jul 2020 23:00:45 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Use ccache and Gradle cache across builds
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16181 )
Change subject: [docker] Use ccache and Gradle cache across builds
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16181/1/docker/Dockerfile
File docker/Dockerfile:
http://gerrit.cloudera.org:8080/#/c/16181/1/docker/Dockerfile@464
PS1, Line 464: ENV UID=1001
: ENV GID=1001
Different 1001 uid/gid here for Impala?
http://gerrit.cloudera.org:8080/#/c/16181/1/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/16181/1/docker/bootstrap-dev-env.sh@107
PS1, Line 107: rm -f $DTLS_RPM
that variable no longer exist
--
To view, visit http://gerrit.cloudera.org:8080/16181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Gerrit-Change-Number: 16181
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Jul 2020 17:24:18 +0000
Gerrit-HasComments: Yes