[jira] [Commented] (DRILL-6583) Add space between pagination links in Profiles (WebUI) list

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540441#comment-16540441 ] 

ASF GitHub Bot commented on DRILL-6583:
---------------------------------------

sohami closed pull request #1369: DRILL-6583: Add space between pagination links in Profiles (WebUI) list
URL: https://github.com/apache/drill/pull/1369
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/exec/java-exec/src/main/resources/rest/profile/list.ftl b/exec/java-exec/src/main/resources/rest/profile/list.ftl
index f9334b891f0..602a0e328c6 100644
--- a/exec/java-exec/src/main/resources/rest/profile/list.ftl
+++ b/exec/java-exec/src/main/resources/rest/profile/list.ftl
@@ -54,9 +54,12 @@
   /* Control Padding for length and filter as a pair */
   div.dataTables_length {
     float: right;
+    font-weight: normal;
   }
   div.dataTables_filter {
     float: left;
+    font-weight: normal;
+    padding-left: 0.45em;
   }
   div.dataTables_info {
     padding-right: 2em;
@@ -64,19 +67,10 @@
   }
 
   /* Add spaces between pagination links */
-  #profileList_paginate * {
-    padding-right: 0.55em;
-    float:left
+  #profileList_completed_paginate *, #profileList_running_paginate * { 
+    padding-right: 0.35em; 
+    float:left 
   }
-  /* Normal wt for search text */
-  #profileList_filter input {
-    font-weight: normal;
-    padding-left: 0.45em;
-  }
-  #profileList_length * {
-    font-weight: normal;
-  }
-
 </style>
 
 </#macro>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add space between pagination links in Profiles (WebUI) list
> -----------------------------------------------------------
>
>                 Key: DRILL-6583
>                 URL: https://issues.apache.org/jira/browse/DRILL-6583
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>    Affects Versions: 1.14.0
>            Reporter: Khurram Faraaz
>            Assignee: Kunal Khatua
>            Priority: Minor
>              Labels: ready-to-commit
>             Fix For: 1.14.0
>
>         Attachments: UI_usability_issue_AD_1_14_0.png
>
>
> When a query is under execution, on the web UI we see this text which is actually a set of different links that help navigate to different pages on the UI, below that query's profile.
> Apache Drill 1.14.0
> git.commit.id.abbrev=f481a7c
> They all appear on a single line with no spacing and a typo, the formatting of the text for those links needs to be changed / improved.
> Attached is a screenshot for the issue, look for "FirstPrevious1NextLast" on the bottom left of the screenshot.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)