You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/21 02:48:13 UTC
[GitHub] [airflow] humbledude opened a new issue #11710: JDBC connect string from connection uri parsed wrongly
humbledude opened a new issue #11710:
URL: https://github.com/apache/airflow/issues/11710
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
These questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**: 1.10.12
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.15.11
**Environment**:
- **Cloud provider or hardware configuration**:
- **OS** (e.g. from /etc/os-release):
- **Kernel** (e.g. `uname -a`):
- **Install tools**:
- **Others**:
**What happened**:
I was testing [Hashcorp Vault SecretBackend](https://airflow.apache.org/docs/stable/howto/use-alternative-secrets-backend.html#hashicorp-vault-secrets-backend) + [SqoopOperator](https://airflow.apache.org/docs/stable/_api/airflow/contrib/operators/sqoop_operator/index.html?highlight=sqoopoperator#airflow.contrib.operators.sqoop_operator.SqoopOperator)
And I found if I use `JDBC connect string` value on [uri format that suggested by Airflow](https://airflow.apache.org/docs/stable/howto/connection/index.html#generating-connection-uri), `JDBC connect string` parsed wrongly.
JDBC connect string example: `jdbc:postgresql://username:password@host:port?param1=value1¶m2=value2`
I found it is caused by `urllib.parse.urlparse` and `airflow.models.connection.Connection` uses the code [here](https://github.com/apache/airflow/blob/3a45f1f84d515bdf3bd32dca5418f1920f18dd5f/airflow/models/connection.py#L204)
If I use alternative secret backend, it seems using [uri format that suggested by Airflow](https://airflow.apache.org/docs/stable/howto/connection/index.html#generating-connection-uri) is the only choice.
I think Airflow should provide another option for support JDBC connect string for alternative secret backends.
Thank you.
<!-- (please include exact error messages if you can) -->
**What you expected to happen**:
<!-- What do you think went wrong? -->
**How to reproduce it**:
<!---
As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
## Install minikube/kind
- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/
If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
You can include images using the .md style of
To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
--->
**Anything else we need to know**:
<!--
How often does this problem occur? Once? Every time etc?
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on issue #11710: JDBC connect string from connection uri parsed wrongly
Posted by GitBox <gi...@apache.org>.
dstandish commented on issue #11710:
URL: https://github.com/apache/airflow/issues/11710#issuecomment-981884415
Hi @humbledude
I think you may be confusing the two types of URIs here.
The [airflow connection uri](https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#connection-uri-format) is a mechanism of serializing airlfow's Connection object to a string.
You can't just take a jdbc URI and expect it to parse as an airflow connection. Airflow hooks parse airflow Connection objects in many different ways and you have to understand what the hook is looking for in order build the connection in the right way.
First you should replace `jdbc:postgres` with `sqoop` in your connection URI. this change alone will probably make it parse.
But next you need to debug your URI to make sure it is interpreted by the hook in the right way.
Looking at the sqoop hook, I see there is a `_prepare_command` method that would be useful for debugging the command.
You can call this method and examine the output. If necessary, change your uri.
You can use `Connection.get_uri` to produce a URI given an airflow Connection object.
Closing for now, let us know if you continue to have trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish closed issue #11710: JDBC connect string from connection uri parsed wrongly
Posted by GitBox <gi...@apache.org>.
dstandish closed issue #11710:
URL: https://github.com/apache/airflow/issues/11710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #11710: JDBC connect string from connection uri parsed wrongly
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #11710:
URL: https://github.com/apache/airflow/issues/11710#issuecomment-713258883
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org