You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/03/23 15:51:37 UTC
[GitHub] [jena] Claudenw opened a new pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Claudenw opened a new pull request #964:
URL: https://github.com/apache/jena/pull/964
Changes are in AltImpl.setDefault(), ContainerImpl.add(),
ContainerImpl.contains(), SeqImpl.add(), and SeqImpl.indexOf()
This should fix JENA-2075 for ver 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #964:
URL: https://github.com/apache/jena/pull/964#issuecomment-805644186
Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs closed pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
afs closed pull request #964:
URL: https://github.com/apache/jena/pull/964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] Claudenw commented on pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
Claudenw commented on pull request #964:
URL: https://github.com/apache/jena/pull/964#issuecomment-805640095
OK, I'll reapply the changes to jena3 branch and resubmit a pull request.
thx
On Wed, Mar 24, 2021 at 9:23 AM Andy Seaborne ***@***.***>
wrote:
> Are we not updating the master (3.x) branch at this point?
>
> The 3.x branch is "jena3". "master" only exists to smooth the transition
> to "main" and will be deleted sometime.
>
> Sorry - missed the subtle of the two PRs.
>
> Branch "jena3" has not had any changes applied to it since it was created
> at that split point.
>
> The branch marks the transition to java11 which is the trigger for Jena4.
> Jena4 is not radically different.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/jena/pull/964#issuecomment-805638961>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AASTVHRE2NTKGIJHIZDRP7TTFGVS3ANCNFSM4ZVOSZ3Q>
> .
>
--
I like: Like Like - The likeliest place on the web
<http://like-like.xenei.com>
LinkedIn: http://www.linkedin.com/in/claudewarren
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] Claudenw commented on pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
Claudenw commented on pull request #964:
URL: https://github.com/apache/jena/pull/964#issuecomment-805657127
Because they are wrong and because a number of projects use version 3 and
probably will for awhile as 4 rolls out.
On Wed, Mar 24, 2021 at 9:30 AM Andy Seaborne ***@***.***>
wrote:
> Why?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/jena/pull/964#issuecomment-805644186>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AASTVHQAKZBYF5CTIKPTJ73TFGWL5ANCNFSM4ZVOSZ3Q>
> .
>
--
I like: Like Like - The likeliest place on the web
<http://like-like.xenei.com>
LinkedIn: http://www.linkedin.com/in/claudewarren
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
rvesse commented on pull request #964:
URL: https://github.com/apache/jena/pull/964#issuecomment-805661129
As a project we have never committed to maintaining more than one major version. We simply don't have the volunteer manpower to actively maintain multiple branches like other corporate backed big name ASF projects can.
Our aim has always been to encourage people to migrate forward to the latest supported version. Yes there will always be folks who don't/can't upgrade in a timely fashion but we don't have any control over that. The past response to "this is broken in this old version" has always been "have you tried the latest?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] Claudenw commented on pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
Claudenw commented on pull request #964:
URL: https://github.com/apache/jena/pull/964#issuecomment-805618587
Are we not updating the master (3.x) branch at this point? I think this change should be applied to 3.x as well as 4.x thus the 2 merge requests: one for master, one for main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #964:
URL: https://github.com/apache/jena/pull/964#issuecomment-805638961
> Are we not updating the master (3.x) branch at this point?
The 3.x branch is "jena3". "master" only exists to smooth the transition to "main" and will be deleted sometime.
Sorry - missed the subtle of the two PRs.
Branch "jena3" has not had any changes applied to it since it was created at that split point.
The branch marks the transition to java11 which is the trigger for Jena4. Jena4 is not radically different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs edited a comment on pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
afs edited a comment on pull request #964:
URL: https://github.com/apache/jena/pull/964#issuecomment-805638961
> Are we not updating the master (3.x) branch at this point?
The 3.x branch is "jena3". "master" only exists to smooth the transition to "main" and will be deleted sometime.
Sorry - missed the subtlety of the two PRs.
Branch "jena3" has not had any changes applied to it since it was created at that split point.
The branch marks the transition to java11 which is the trigger for Jena4. Jena4 is not radically different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #964:
URL: https://github.com/apache/jena/pull/964#issuecomment-805075070
Closed because this is the same as #965 except "ver 3" -> "ver 4" above (diff compared).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #964: Changed String.valueOf() to getModel().createTypeLiteral()
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #964:
URL: https://github.com/apache/jena/pull/964#issuecomment-805712410
The code has been that (wrong) way for a very, very long time (pre-Apache).
@Claudenw - Are you talking about projects which are fixed to Java8 by their IT environment? Would such projects upgrade anyway? Can they do a local build?
Jena4 isn't that different.
The Jena3 branch stopped at Feb 8th and so has no general fixes since then. It does include the start of IRIx.
This container change and the rename of RDFWriter/RDFReader interfaces are the only Model API changes.
Jena 4.0.0 builds with Java8 in the cautious rollout, as discussed.
If we keep support at the pace of the slowest downstream project (whoever theyare), we need more people-time to maintain the codebase. Time has gone on making sure it is forward-compatible, with build infrastructure to check.
As @rvesse says - we need to match supply and demand. We carefully evolve. So far, that has worked well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org