You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/10 09:44:35 UTC
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request #5097: Update chain info of the volumes after migrate operations
harikrishna-patnala opened a new pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097
### Description
This PR fixes the problem of not updating the chain info or setting chain info to null after volume migrations.
Problem: While fetching the volume chain info, management server assumes datastore name to be a UUID (this is true only for NFS storages added by CloudStack) but datastore name can be with any name.
Solution: To fetch the volume chain info, use datastore name instead of UUID.
The fix is made in the flow of following API operations
1. migrateVirtualMachine
2. migrateVirtualMachineWithVolume
3. migrateVolume
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Created one NFS, one datastore cluster (with two child storages with names "child1", "child2") primary storages
1. Migrated a volume from NFS to datastore cluster. 'chain_info' in "volumes" table is updated
Before migration
After migration
2. Migrated volume from datastore cluster to NFS storage. 'chain_info' in "volumes" table is updated
3. called APIs migrateVirtualMachine and migrateVirtualMachineWithVolumes to migrate volumes from NFS to datastore cluster and datastore cluster to NFS, all succeeded and updated the chain_info accordingly.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-858544474
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-859626425
Merging this based on review, manual tests and smoketests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-859381013
> Ping @mib1185 @DK101010 can you review/test this in your fork?
@rhtyd tests were successful - works like a charm now 👍
@harikrishna-patnala many thanks for the fast support und provided fix 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-858544848
@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 edited a comment on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
mib1185 edited a comment on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-859381013
> Ping @mib1185 @DK101010 can you review/test this in your fork?
@rhtyd tests were successful - works like a charm now 👍
@harikrishna-patnala many thanks for the fast support and provided fix 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-859214927
<b>Trillian test result (tid-906)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52249 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5097-t906-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 601.04 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 627.55 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 551.77 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 586.83 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-858626497
> Ping @mib1185 @DK101010 can you review/test this in your fork?
Hi @rhtyd, @harikrishna-patnala I will test this. Many thanks for your quick support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-858478228
@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-858559072
Ping @mib1185 @DK101010 can you review/test this in your fork?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-858477947
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5097: Update chain info of the volumes after migrate operations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-858496407
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org