[GitHub] [pinot] walterddr commented on a diff in pull request #9657: adding null integration test

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9657:
URL: https://github.com/apache/pinot/pull/9657#discussion_r1005102045


##########
pinot-core/src/test/java/org/apache/pinot/queries/NullEnabledQueriesTest.java:
##########
@@ -317,16 +395,17 @@ public void testQueries(Number baseValue, ColumnDataType dataType, boolean nullV
           //(3 rows)
           assertEquals(row[3], 0L);
         } else if ((int) row[keyColumnIdx] == 1) {
-          assertTrue(Math.abs(((Double) row[0]) - 4 * _sumKey1) < 1e-1);
-          assertTrue(Math.abs(((Double) row[1]) - baseValue.doubleValue()) < 1e-1);
+          assertTrue(Math.abs(((Double) row[0]) - 4 * _sumKey1) < PRECISION);

Review Comment:
   yeah this was for integer and long in the future. but yes i can make it 1e-1 for now until we add other types



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org