You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@impala.apache.org by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org> on 2016/06/22 02:40:59 UTC

[Impala-CR](cdh5-trunk) Cleanup Python test import statements

Taras Bobrovytsky has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3444

Change subject: Cleanup Python test import statements
......................................................................

Cleanup Python test import statements

Many of our test scripts have import statements that look like
"from xxx import *". It is a good practice to explicitly name what
needs to be imported. This commit implements this practice.

Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
---
M tests/catalog_service/test_catalog_service_client.py
M tests/catalog_service/test_hms_failure.py
M tests/catalog_service/test_large_num_partitions.py
M tests/common/base_test_suite.py
M tests/common/failure_injector.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_admission_controller.py
M tests/experiments/test_targeted_perf.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/metadata/test_explain.py
M tests/metadata/test_hdfs_encryption.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_hidden_files.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/metadata/test_set.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_stale_metadata.py
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_chars.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_decimal_queries.py
M tests/query_test/test_delimited_text.py
M tests/query_test/test_exprs.py
M tests/query_test/test_hbase_queries.py
M tests/query_test/test_hdfs_caching.py
M tests/query_test/test_hdfs_fd_caching.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_join_queries.py
M tests/query_test/test_kudu.py
M tests/query_test/test_limit.py
M tests/query_test/test_mem_usage_scaling.py
M tests/query_test/test_nested_types.py
M tests/query_test/test_partitioning.py
M tests/query_test/test_queries.py
M tests/query_test/test_query_mem_limit.py
M tests/query_test/test_runtime_filters.py
M tests/query_test/test_scanners.py
M tests/query_test/test_sort.py
M tests/query_test/test_timezones.py
M tests/query_test/test_tpcds_queries.py
M tests/query_test/test_tpch_nested_queries.py
M tests/query_test/test_tpch_queries.py
M tests/query_test/test_udfs.py
M tests/unittests/test_file_parser.py
M tests/unittests/test_result_verifier.py
M tests/util/compute_table_stats.py
57 files changed, 211 insertions(+), 154 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/44/3444/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.

Internal Jenkins has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 3: Verified-1

Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge/2615/

-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.

Internal Jenkins has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.

Taras Bobrovytsky has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 3:

This was tested on S3 and exhaustive and the builds passed:
http://sandbox.jenkins.cloudera.com/view/Impala/view/Private-Utility/job/impala-private-build-and-test-s3/175/
http://sandbox.jenkins.cloudera.com/view/Impala/view/Private-Utility/job/impala-private-build-and-test/3691/

-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.

Taras Bobrovytsky has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 2:

This change was built successfully and all tests passed: http://sandbox.jenkins.cloudera.com/view/Impala/view/Private-Utility/job/impala-private-build-and-test/3531/

-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) Cleanup Python test import statements

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.

Tim Armstrong has posted comments on this change.

Change subject: Cleanup Python test import statements
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.

Taras Bobrovytsky has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 3:

I removed the query generator changes from this patch, so the third test you suggested is not necessary.

-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.

Taras Bobrovytsky has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 3:

I used pyflakes for this. Then I ran the following command in $IMPALA_HOME/tests: find . -name "*.py" -exec pyflakes {} \;

It printed out all unused variables and imports.

-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.

Taras Bobrovytsky has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 2:

Thanks for the +2, Tim. I had to make some changes to make the build green since the last patch. Also removed unused Import statements.

-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.

Michael Brown has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 2:

(2 comments)

Can you run the following tests:

1. debug build / exhaustive tests / HDFS
2. debug build / core tests / S3
3. query generator / leopard smoke test

http://gerrit.cloudera.org:8080/#/c/3444/2/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

Line 933
Whoops. Is this the correct fix though? How will this work without using a MySQLdb connection? Why not merge the two MySQLConnection classes' methods?


http://gerrit.cloudera.org:8080/#/c/3444/2/tests/comparison/query.py
File tests/comparison/query.py:

PS2, Line 613:     return LimitClause(self.limit)
This isn't an import change. Was it intentional in this patch?


-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.

Michael Brown has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 3: Code-Review+2

I didn't review that all your imports were truly functionally correct, of course, but I'm satisfied doing an exhaustive test run and a test run of at least one other filesystem is enough to verify import changes are still working. Furthermore your test runs are recent enough that this seems OK.

I looked more carefully at the non-import changes in this patch, such as removing unneeded variables, and those look fine.

Do you mind sharing what tools you used to do this? I'm only familiar with flake8 and there are so many other flake8 violations in our python that I don't use that on the entire python codebase.

-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.

Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3444

to look at the new patch set (#3).

Change subject: Clean up Python test import statements
......................................................................

Clean up Python test import statements

Many of our test scripts have import statements that look like
"from xxx import *". It is a good practice to explicitly name what
needs to be imported. This commit implements this practice. Also,
unused import statements are removed.

Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
---
M tests/authorization/test_grant_revoke.py
M tests/beeswax/impala_beeswax.py
M tests/catalog_service/test_catalog_service_client.py
M tests/catalog_service/test_hms_failure.py
M tests/catalog_service/test_large_num_partitions.py
M tests/common/base_test_suite.py
M tests/common/custom_cluster_test_suite.py
M tests/common/failure_injector.py
M tests/common/impala_cluster.py
M tests/common/impala_connection.py
M tests/common/impala_service.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
M tests/common/test_result_verifier.py
M tests/common/test_vector.py
M tests/custom_cluster/test_admission_controller.py
M tests/custom_cluster/test_alloc_fail.py
M tests/custom_cluster/test_breakpad.py
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_delegation.py
M tests/custom_cluster/test_hdfs_fd_caching.py
M tests/custom_cluster/test_insert_behaviour.py
M tests/custom_cluster/test_legacy_joins_aggs.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_permanent_udfs.py
M tests/custom_cluster/test_query_expiration.py
M tests/custom_cluster/test_s3a_access.py
M tests/custom_cluster/test_scratch_disk.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_spilling.py
M tests/data_errors/test_data_errors.py
M tests/experiments/test_process_failures.py
M tests/experiments/test_targeted_perf.py
M tests/failure/test_failpoints.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/metadata/test_explain.py
M tests/metadata/test_hdfs_encryption.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_hidden_files.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_load.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/metadata/test_set.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_stale_metadata.py
M tests/metadata/test_views_compatibility.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/scheduler.py
M tests/performance/workload.py
M tests/performance/workload_runner.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_analytic_tpcds.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_chars.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_decimal_casting.py
M tests/query_test/test_decimal_queries.py
M tests/query_test/test_delimited_text.py
M tests/query_test/test_exprs.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_hbase_queries.py
M tests/query_test/test_hdfs_caching.py
M tests/query_test/test_hdfs_fd_caching.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_join_queries.py
M tests/query_test/test_kudu.py
M tests/query_test/test_limit.py
M tests/query_test/test_mem_usage_scaling.py
M tests/query_test/test_multiple_filesystems.py
M tests/query_test/test_nested_types.py
M tests/query_test/test_partitioning.py
M tests/query_test/test_queries.py
M tests/query_test/test_query_mem_limit.py
M tests/query_test/test_query_opts.py
M tests/query_test/test_runtime_filters.py
M tests/query_test/test_scanners.py
M tests/query_test/test_sort.py
M tests/query_test/test_timezones.py
M tests/query_test/test_tpcds_queries.py
M tests/query_test/test_tpch_nested_queries.py
M tests/query_test/test_tpch_queries.py
M tests/query_test/test_udfs.py
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/statestore/test_statestore.py
M tests/stress/test_ddl_stress.py
M tests/stress/test_mini_stress.py
M tests/unittests/test_file_parser.py
M tests/unittests/test_result_verifier.py
M tests/util/compute_table_stats.py
M tests/util/hdfs_util.py
M tests/util/plugin_runner.py
M tests/util/s3_util.py
M tests/util/test_file_parser.py
M tests/verifiers/metric_verifier.py
M tests/verifiers/test_verify_metrics.py
106 files changed, 368 insertions(+), 487 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/44/3444/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.

Taras Bobrovytsky has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3444/2/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

Line 933
> Whoops. Is this the correct fix though? How will this work without using a 
I removed all query generator changes from this patch, so this is no longer relevant. This can be fixed in a different patch.


http://gerrit.cloudera.org:8080/#/c/3444/2/tests/comparison/query.py
File tests/comparison/query.py:

PS2, Line 613:     return LimitClause(self.limit)
> This isn't an import change. Was it intentional in this patch?
I removed all query generator changes from this patch, so this is no longer relevant.


-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.

Internal Jenkins has submitted this change and it was merged.

Change subject: Clean up Python test import statements
......................................................................


Clean up Python test import statements

Many of our test scripts have import statements that look like
"from xxx import *". It is a good practice to explicitly name what
needs to be imported. This commit implements this practice. Also,
unused import statements are removed.

Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Reviewed-on: http://gerrit.cloudera.org:8080/3444
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Internal Jenkins
---
M tests/authorization/test_grant_revoke.py
M tests/beeswax/impala_beeswax.py
M tests/catalog_service/test_catalog_service_client.py
M tests/catalog_service/test_hms_failure.py
M tests/catalog_service/test_large_num_partitions.py
M tests/common/base_test_suite.py
M tests/common/custom_cluster_test_suite.py
M tests/common/failure_injector.py
M tests/common/impala_cluster.py
M tests/common/impala_connection.py
M tests/common/impala_service.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
M tests/common/test_result_verifier.py
M tests/common/test_vector.py
M tests/custom_cluster/test_admission_controller.py
M tests/custom_cluster/test_alloc_fail.py
M tests/custom_cluster/test_breakpad.py
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_delegation.py
M tests/custom_cluster/test_hdfs_fd_caching.py
M tests/custom_cluster/test_insert_behaviour.py
M tests/custom_cluster/test_legacy_joins_aggs.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_permanent_udfs.py
M tests/custom_cluster/test_query_expiration.py
M tests/custom_cluster/test_s3a_access.py
M tests/custom_cluster/test_scratch_disk.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_spilling.py
M tests/data_errors/test_data_errors.py
M tests/experiments/test_process_failures.py
M tests/experiments/test_targeted_perf.py
M tests/failure/test_failpoints.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/metadata/test_explain.py
M tests/metadata/test_hdfs_encryption.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_hidden_files.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_load.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/metadata/test_set.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_stale_metadata.py
M tests/metadata/test_views_compatibility.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/scheduler.py
M tests/performance/workload.py
M tests/performance/workload_runner.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_analytic_tpcds.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_chars.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_decimal_casting.py
M tests/query_test/test_decimal_queries.py
M tests/query_test/test_delimited_text.py
M tests/query_test/test_exprs.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_hbase_queries.py
M tests/query_test/test_hdfs_caching.py
M tests/query_test/test_hdfs_fd_caching.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_join_queries.py
M tests/query_test/test_kudu.py
M tests/query_test/test_limit.py
M tests/query_test/test_mem_usage_scaling.py
M tests/query_test/test_multiple_filesystems.py
M tests/query_test/test_nested_types.py
M tests/query_test/test_partitioning.py
M tests/query_test/test_queries.py
M tests/query_test/test_query_mem_limit.py
M tests/query_test/test_query_opts.py
M tests/query_test/test_runtime_filters.py
M tests/query_test/test_scanners.py
M tests/query_test/test_sort.py
M tests/query_test/test_timezones.py
M tests/query_test/test_tpcds_queries.py
M tests/query_test/test_tpch_nested_queries.py
M tests/query_test/test_tpch_queries.py
M tests/query_test/test_udfs.py
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/statestore/test_statestore.py
M tests/stress/test_ddl_stress.py
M tests/stress/test_mini_stress.py
M tests/unittests/test_file_parser.py
M tests/unittests/test_result_verifier.py
M tests/util/compute_table_stats.py
M tests/util/hdfs_util.py
M tests/util/plugin_runner.py
M tests/util/s3_util.py
M tests/util/test_file_parser.py
M tests/verifiers/metric_verifier.py
M tests/verifiers/test_verify_metrics.py
106 files changed, 368 insertions(+), 487 deletions(-)

Approvals:
  Michael Brown: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-CR](cdh5-trunk) Clean up Python test import statements

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.

Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3444

to look at the new patch set (#2).

Change subject: Clean up Python test import statements
......................................................................

Clean up Python test import statements

Many of our test scripts have import statements that look like
"from xxx import *". It is a good practice to explicitly name what
needs to be imported. This commit implements this practice. Also,
unused import statements are removed.

Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
---
M tests/authorization/test_grant_revoke.py
M tests/beeswax/impala_beeswax.py
M tests/catalog_service/test_catalog_service_client.py
M tests/catalog_service/test_hms_failure.py
M tests/catalog_service/test_large_num_partitions.py
M tests/common/base_test_suite.py
M tests/common/custom_cluster_test_suite.py
M tests/common/failure_injector.py
M tests/common/impala_cluster.py
M tests/common/impala_connection.py
M tests/common/impala_service.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
M tests/common/test_result_verifier.py
M tests/common/test_vector.py
M tests/comparison/db_connection.py
M tests/comparison/leopard/controller.py
M tests/comparison/leopard/front_end.py
M tests/comparison/leopard/job.py
M tests/comparison/leopard/report.py
M tests/comparison/leopard/schedule_item.py
M tests/comparison/query.py
M tests/custom_cluster/test_admission_controller.py
M tests/custom_cluster/test_alloc_fail.py
M tests/custom_cluster/test_breakpad.py
M tests/custom_cluster/test_delegation.py
M tests/custom_cluster/test_hdfs_fd_caching.py
M tests/custom_cluster/test_insert_behaviour.py
M tests/custom_cluster/test_legacy_joins_aggs.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_permanent_udfs.py
M tests/custom_cluster/test_query_expiration.py
M tests/custom_cluster/test_s3a_access.py
M tests/custom_cluster/test_scratch_disk.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_spilling.py
M tests/data_errors/test_data_errors.py
M tests/experiments/test_process_failures.py
M tests/experiments/test_targeted_perf.py
M tests/failure/test_failpoints.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/metadata/test_explain.py
M tests/metadata/test_hdfs_encryption.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_hidden_files.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_load.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/metadata/test_set.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_stale_metadata.py
M tests/metadata/test_views_compatibility.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/scheduler.py
M tests/performance/workload.py
M tests/performance/workload_runner.py
M tests/query_test/test_aggregation.py
M tests/query_test/test_analytic_tpcds.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_chars.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_decimal_casting.py
M tests/query_test/test_decimal_queries.py
M tests/query_test/test_delimited_text.py
M tests/query_test/test_exprs.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_hbase_queries.py
M tests/query_test/test_hdfs_caching.py
M tests/query_test/test_hdfs_fd_caching.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_insert_permutation.py
M tests/query_test/test_join_queries.py
M tests/query_test/test_kudu.py
M tests/query_test/test_limit.py
M tests/query_test/test_mem_usage_scaling.py
M tests/query_test/test_multiple_filesystems.py
M tests/query_test/test_nested_types.py
M tests/query_test/test_partitioning.py
M tests/query_test/test_queries.py
M tests/query_test/test_query_mem_limit.py
M tests/query_test/test_query_opts.py
M tests/query_test/test_runtime_filters.py
M tests/query_test/test_scanners.py
M tests/query_test/test_sort.py
M tests/query_test/test_timezones.py
M tests/query_test/test_tpcds_queries.py
M tests/query_test/test_tpch_nested_queries.py
M tests/query_test/test_tpch_queries.py
M tests/query_test/test_udfs.py
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/statestore/test_statestore.py
M tests/stress/test_ddl_stress.py
M tests/stress/test_mini_stress.py
M tests/unittests/test_file_parser.py
M tests/unittests/test_result_verifier.py
M tests/util/compute_table_stats.py
M tests/util/hdfs_util.py
M tests/util/plugin_runner.py
M tests/util/s3_util.py
M tests/util/test_file_parser.py
M tests/verifiers/metric_verifier.py
M tests/verifiers/test_verify_metrics.py
112 files changed, 381 insertions(+), 524 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/44/3444/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>