You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/01/13 11:17:39 UTC
[GitHub] [echarts] pissang opened a new pull request #16368: feat(state): add emphasis.disabled
pissang opened a new pull request #16368:
URL: https://github.com/apache/echarts/pull/16368
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
Introduce `emphasis.disabled` to disable emphasis state on hover and tooltip trigger. `Previously` we can only use `silent` to disable any hover interactions. But it will also lost the mouse event.
By disabling `emphasis` state. We can avoid potential performance issue when interacting with massive data like in https://github.com/apache/echarts/issues/16133 . Or remove unwanted highlight / emphasis effect like in https://github.com/apache/echarts/issues/14952
Also ee related `select.disabled` [PR](https://github.com/apache/echarts/pull/15534) by @susiwen8 .
### Fixed issues
https://github.com/apache/echarts/issues/14952
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [x] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
Disable emphasis state of whole series
```ts
series: [{
emphasis: {
disabled: true
}
}]
```
Disable emphasis state of single data
```ts
series: [{
data: [{
name: 'xxx',
emphasis: { disabled: true }
}]
}]
```
Disable emphasis state in custom series
```ts
renderItem() {
return {
type: 'group',
emphasisDisabled: true
}
}
```
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #16368:
URL: https://github.com/apache/echarts/pull/16368#issuecomment-1013078533
@plainheart Turns out it's a very stupid typo. https://github.com/ecomfe/zrender/pull/872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16368:
URL: https://github.com/apache/echarts/pull/16368#issuecomment-1012041098
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #16368:
URL: https://github.com/apache/echarts/pull/16368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #16368:
URL: https://github.com/apache/echarts/pull/16368#issuecomment-1013078533
@plainheart Turns out it's a very stupid typo. https://github.com/ecomfe/zrender/compare/fix-gradient-animation?expand=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #16368:
URL: https://github.com/apache/echarts/pull/16368#issuecomment-1013026277
@plainheart Seems it's introduced by gradient color highlight and animation in https://github.com/apache/echarts/pull/16225 https://github.com/ecomfe/zrender/pull/857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #16368:
URL: https://github.com/apache/echarts/pull/16368#issuecomment-1013078533
@plainheart Turns out it's a very stupid typo. https://github.com/ecomfe/zrender/pull/872 . Also added a interaction record for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16368:
URL: https://github.com/apache/echarts/pull/16368#issuecomment-1013126800
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #16368:
URL: https://github.com/apache/echarts/pull/16368#issuecomment-1013078533
@plainheart Turns out it's a very stupid typo. https://github.com/ecomfe/zrender/pull/872 . Also added new user interaction record for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #16368:
URL: https://github.com/apache/echarts/pull/16368#issuecomment-1013026277
@plainheart Seems it's introduced by gradient color highlight and animation in https://github.com/apache/echarts/pull/16225 and https://github.com/ecomfe/zrender/pull/857 . Will take a look at it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #16368: feat(state): add emphasis.disabled
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #16368:
URL: https://github.com/apache/echarts/pull/16368#issuecomment-1013078533
@plainheart Turns out it's a very stupid typo. https://github.com/ecomfe/zrender/pull/872 . Also added a user interaction record for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org