You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/22 07:24:58 UTC
Review Request 56922: Hive2: Query in query editor is getting
modified while navigating across different tabs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56922/
-----------------------------------------------------------
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20111
https://issues.apache.org/jira/browse/AMBARI-20111
Repository: ambari
Description
-------
Saving the right value in the model.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/configs/result-tabs.js f48dcd8
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 9196d8b
contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js c2a0c8c
contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs c3d907d
Diff: https://reviews.apache.org/r/56922/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56922: Hive2: Query in query editor is getting
modified while navigating across different tabs
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56922/#review166341
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Feb. 22, 2017, 7:24 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56922/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 7:24 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20111
> https://issues.apache.org/jira/browse/AMBARI-20111
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Saving the right value in the model.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/configs/result-tabs.js f48dcd8
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 9196d8b
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js c2a0c8c
> contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs c3d907d
>
> Diff: https://reviews.apache.org/r/56922/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56922: Hive2: Query in query editor is getting
modified while navigating across different tabs
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56922/#review166329
-----------------------------------------------------------
Ship it!
Ship It!
- venkat sairam
On Feb. 22, 2017, 7:24 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56922/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 7:24 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20111
> https://issues.apache.org/jira/browse/AMBARI-20111
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Saving the right value in the model.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/configs/result-tabs.js f48dcd8
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 9196d8b
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js c2a0c8c
> contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs c3d907d
>
> Diff: https://reviews.apache.org/r/56922/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56922: Hive2: Query in query editor is getting
modified while navigating across different tabs
Posted by Abhishek Kumar <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56922/#review166331
-----------------------------------------------------------
Ship it!
Ship It!
- Abhishek Kumar
On Feb. 22, 2017, 7:24 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56922/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 7:24 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20111
> https://issues.apache.org/jira/browse/AMBARI-20111
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Saving the right value in the model.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/configs/result-tabs.js f48dcd8
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 9196d8b
> contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js c2a0c8c
> contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs c3d907d
>
> Diff: https://reviews.apache.org/r/56922/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>