You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Yakov Kopel (Created) (JIRA)" <ji...@apache.org> on 2011/12/18 16:30:30 UTC
[jira] [Created] (TS-1055) Wrong implementation of TSHttpSsnArgGet
Wrong implementation of TSHttpSsnArgGet
---------------------------------------
Key: TS-1055
URL: https://issues.apache.org/jira/browse/TS-1055
Project: Traffic Server
Issue Type: Bug
Components: TS API
Affects Versions: 3.1.1
Reporter: Yakov Kopel
Fix For: 3.1.1
There is a different between the interface of TSHttpSsnArgGet and it implemenation.
In the interface (proxy/api/ts/ts.h.in):
tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
In the implementation(proxy/InkAPI.cc):
void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
So, I wrote a simple patch to fix this problem:
Index: InkAPI.cc
===================================================================
--- InkAPI.cc (revision 1220421)
+++ InkAPI.cc (working copy)
@@ -5500,7 +5500,7 @@
}
void *
-TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
+TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
{
sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1055) Wrong implementation of TSHttpSsnArgGet
Posted by "Igor Galić (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić updated TS-1055:
---------------------------
Backport to Version: (was: 3.0.3)
Fix Version/s: 3.0.3
backported in 63f2267d28daa840712d3ea15d49495c18572f0e
> Wrong implementation of TSHttpSsnArgGet
> ---------------------------------------
>
> Key: TS-1055
> URL: https://issues.apache.org/jira/browse/TS-1055
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.1.1
> Reporter: Yakov Kopel
> Assignee: Igor Galić
> Labels: api-change
> Fix For: 3.1.2, 3.0.3
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There is a different between the interface of TSHttpSsnArgGet and it implemenation.
> In the interface (proxy/api/ts/ts.h.in):
> tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
> In the implementation(proxy/InkAPI.cc):
> void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> So, I wrote a simple patch to fix this problem:
> Index: InkAPI.cc
> ===================================================================
> --- InkAPI.cc (revision 1220421)
> +++ InkAPI.cc (working copy)
> @@ -5500,7 +5500,7 @@
> }
> void *
> -TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> +TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
> {
> sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
> sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1055) Wrong implementation of TSHttpSsnArgGet
Posted by "Igor Galić (Assigned JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić reassigned TS-1055:
------------------------------
Assignee: Igor Galić (was: Leif Hedstrom)
> Wrong implementation of TSHttpSsnArgGet
> ---------------------------------------
>
> Key: TS-1055
> URL: https://issues.apache.org/jira/browse/TS-1055
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.1.1
> Reporter: Yakov Kopel
> Assignee: Igor Galić
> Labels: api-change
> Fix For: 3.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There is a different between the interface of TSHttpSsnArgGet and it implemenation.
> In the interface (proxy/api/ts/ts.h.in):
> tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
> In the implementation(proxy/InkAPI.cc):
> void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> So, I wrote a simple patch to fix this problem:
> Index: InkAPI.cc
> ===================================================================
> --- InkAPI.cc (revision 1220421)
> +++ InkAPI.cc (working copy)
> @@ -5500,7 +5500,7 @@
> }
> void *
> -TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> +TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
> {
> sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
> sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1055) Wrong implementation of TSHttpSsnArgGet
Posted by "Leif Hedstrom (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-1055.
-------------------------------
Resolution: Fixed
Closing for now, reopen if/when we decide to backport to 3.0.x.
> Wrong implementation of TSHttpSsnArgGet
> ---------------------------------------
>
> Key: TS-1055
> URL: https://issues.apache.org/jira/browse/TS-1055
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.1.1
> Reporter: Yakov Kopel
> Assignee: Leif Hedstrom
> Labels: api-change
> Fix For: 3.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There is a different between the interface of TSHttpSsnArgGet and it implemenation.
> In the interface (proxy/api/ts/ts.h.in):
> tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
> In the implementation(proxy/InkAPI.cc):
> void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> So, I wrote a simple patch to fix this problem:
> Index: InkAPI.cc
> ===================================================================
> --- InkAPI.cc (revision 1220421)
> +++ InkAPI.cc (working copy)
> @@ -5500,7 +5500,7 @@
> }
> void *
> -TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> +TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
> {
> sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
> sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1055) Wrong implementation of TSHttpSsnArgGet
Posted by "Leif Hedstrom (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-1055:
---------------------------------
Assignee: Leif Hedstrom
> Wrong implementation of TSHttpSsnArgGet
> ---------------------------------------
>
> Key: TS-1055
> URL: https://issues.apache.org/jira/browse/TS-1055
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.1.1
> Reporter: Yakov Kopel
> Assignee: Leif Hedstrom
> Labels: api-change
> Fix For: 3.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There is a different between the interface of TSHttpSsnArgGet and it implemenation.
> In the interface (proxy/api/ts/ts.h.in):
> tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
> In the implementation(proxy/InkAPI.cc):
> void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> So, I wrote a simple patch to fix this problem:
> Index: InkAPI.cc
> ===================================================================
> --- InkAPI.cc (revision 1220421)
> +++ InkAPI.cc (working copy)
> @@ -5500,7 +5500,7 @@
> }
> void *
> -TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> +TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
> {
> sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
> sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1055) Wrong implementation of TSHttpSsnArgGet
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-1055:
------------------------------
Fix Version/s: (was: 3.1.1)
3.1.2
> Wrong implementation of TSHttpSsnArgGet
> ---------------------------------------
>
> Key: TS-1055
> URL: https://issues.apache.org/jira/browse/TS-1055
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.1.1
> Reporter: Yakov Kopel
> Assignee: Leif Hedstrom
> Labels: api-change
> Fix For: 3.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There is a different between the interface of TSHttpSsnArgGet and it implemenation.
> In the interface (proxy/api/ts/ts.h.in):
> tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
> In the implementation(proxy/InkAPI.cc):
> void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> So, I wrote a simple patch to fix this problem:
> Index: InkAPI.cc
> ===================================================================
> --- InkAPI.cc (revision 1220421)
> +++ InkAPI.cc (working copy)
> @@ -5500,7 +5500,7 @@
> }
> void *
> -TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> +TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
> {
> sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
> sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1055) Wrong implementation of TSHttpSsnArgGet
Posted by "Igor Galić (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić updated TS-1055:
---------------------------
Backport to Version: 3.0.3
> Wrong implementation of TSHttpSsnArgGet
> ---------------------------------------
>
> Key: TS-1055
> URL: https://issues.apache.org/jira/browse/TS-1055
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.1.1
> Reporter: Yakov Kopel
> Assignee: Leif Hedstrom
> Labels: api-change
> Fix For: 3.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There is a different between the interface of TSHttpSsnArgGet and it implemenation.
> In the interface (proxy/api/ts/ts.h.in):
> tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
> In the implementation(proxy/InkAPI.cc):
> void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> So, I wrote a simple patch to fix this problem:
> Index: InkAPI.cc
> ===================================================================
> --- InkAPI.cc (revision 1220421)
> +++ InkAPI.cc (working copy)
> @@ -5500,7 +5500,7 @@
> }
> void *
> -TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> +TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
> {
> sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
> sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira