You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/19 04:14:51 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32227: [SPARK-35132][BUILD][CORE] Upgrade netty-all to 4.1.63.Final

dongjoon-hyun commented on a change in pull request #32227:
URL: https://github.com/apache/spark/pull/32227#discussion_r615532590



##########
File path: common/network-common/src/main/java/org/apache/spark/network/util/NettyUtils.java
##########
@@ -162,7 +162,6 @@ public static PooledByteBufAllocator createPooledByteBufAllocator(
       Math.min(PooledByteBufAllocator.defaultNumDirectArena(), allowDirectBufs ? numCores : 0),
       PooledByteBufAllocator.defaultPageSize(),
       PooledByteBufAllocator.defaultMaxOrder(),
-      allowCache ? PooledByteBufAllocator.defaultTinyCacheSize() : 0,

Review comment:
       Although there is a description about this, could you add the link to Netty site about this change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org