You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/06/21 01:28:24 UTC
[GitHub] [echarts] xhuz opened a new pull request, #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.
xhuz opened a new pull request, #17252:
URL: https://github.com/apache/echarts/pull/17252
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fixed when multiple continue visualMaps were configured, only one HoverLink binding event succeeded
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
### After: How does it behave after the fixing?
## Document Info
One of the following should be checked.
- [ ] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a diff in pull request #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.
Posted by GitBox <gi...@apache.org>.
plainheart commented on code in PR #17252:
URL: https://github.com/apache/echarts/pull/17252#discussion_r905700457
##########
src/component/visualMap/ContinuousView.ts:
##########
@@ -109,6 +109,9 @@ class ContinuousView extends VisualMapView {
private _api: ExtensionAPI;
+ private _ownHoverLinkFromSeriesMouseOver = (e: ElementEvent) => this._hoverLinkFromSeriesMouseOver(e);
+
+ private _ownHideIndicator = () => this._hideIndicator();
Review Comment:
I think we can refer to the [`SliderZoomView`](https://github.com/apache/echarts/blob/master/src/component/dataZoom/SliderZoomView.ts#L135-L141) and use the same strategy.
Note that since some codes use `this.api` rather than `this._api`, you may need to change them to `this._api` after overriding the `init` function. And the assignment to `this._api` in `doRender` function can be moved into the `init` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17252:
URL: https://github.com/apache/echarts/pull/17252#issuecomment-1161049948
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on pull request #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.
Posted by GitBox <gi...@apache.org>.
plainheart commented on PR #17252:
URL: https://github.com/apache/echarts/pull/17252#issuecomment-1161149828
Thanks for your contribution! Could you please add some test cases for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17252:
URL: https://github.com/apache/echarts/pull/17252#issuecomment-1165154665
⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a diff in pull request #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.
Posted by GitBox <gi...@apache.org>.
plainheart commented on code in PR #17252:
URL: https://github.com/apache/echarts/pull/17252#discussion_r905700457
##########
src/component/visualMap/ContinuousView.ts:
##########
@@ -109,6 +109,9 @@ class ContinuousView extends VisualMapView {
private _api: ExtensionAPI;
+ private _ownHoverLinkFromSeriesMouseOver = (e: ElementEvent) => this._hoverLinkFromSeriesMouseOver(e);
+
+ private _ownHideIndicator = () => this._hideIndicator();
Review Comment:
I think we can refer to the [`SliderZoomView`](https://github.com/apache/echarts/blob/master/src/component/dataZoom/SliderZoomView.ts#L135-L141) and use the same strategy.
Note that since some codes use `this.api` rather than `this._api`, you may need to change them to `this._api` after implementing the `init` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart closed pull request #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.
Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart closed pull request #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.
URL: https://github.com/apache/echarts/pull/17252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on pull request #17252: fix(continuousView): fix multi visualMap bind hoverLink listener.
Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on PR #17252:
URL: https://github.com/apache/echarts/pull/17252#issuecomment-1713796356
Superseded by #19097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org