You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/09/06 13:46:11 UTC

[GitHub] [commons-math] avijitbasak opened a new pull request #197: Feature/math 1563

avijitbasak opened a new pull request #197:
URL: https://github.com/apache/commons-math/pull/197


   Changes for task MATH-1618


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] aherbert commented on pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
aherbert commented on pull request #197:
URL: https://github.com/apache/commons-math/pull/197#issuecomment-913688042


   Thanks for the contribution. There are a few issues to address before a detailed review.
   
   This will fail on checkstyle. You should replace all tab characters with 4 spaces and add new lines at the end of files. You can run a checkstyle report using:
   ```
   mvn checkstyle:checkstyle
   ```
   And then open `target/site/checkstyle.html`.
   
   Before the CI build will pass you can check that the local build passes the default goal. This is:
   ```
   mvn clean verify apache-rat:check checkstyle:check pmd:check spotbugs:check javadoc:javadoc
   ```
   
   You can run the code check targets separately to get a report on what is wrong (outputs will be in the `target/site` directory):
   ```
   mvn checkstyle:checkstyle
   mvn pmd:pmd
   mvn spotbugs:spotbugs
   ```
   
   In general you should check that the module passes the default maven goal:
   ```
   mvn
   ```
   
   You have public interfaces with redundant public keywords on methods or properties.
   
   There is a string property named CHROMOZOME which should be corrected.
   
   The module directory name `commons-math4-genetics` should be `commons-math-genetics`. The 4 is used only in the artifactId.
   
   The class RandomGenerator has a synchronized method to access a singleton. The effect of the synchronized keyword is meaningless here. The returned singleton is not thread-safe. A different design is required if the object is intended to be used across threads. A better approach is a single random generator per thread. The WELL_19937_C generator is not a very robust generator. There are faster and statistically better random generators available. For cross thread generic use you could try for example `ThreadLocalRandomSource.current(RandomSource.XO_RO_SHI_RO_128_PP)`. If you want a thread-pool to avoid sequence collisions/overlap on the random output from the generator used by each thread then this will require creating threads with a child generator, each created from the same parent `JumpableUniformRandomProvider`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] aherbert commented on a change in pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
aherbert commented on a change in pull request #197:
URL: https://github.com/apache/commons-math/pull/197#discussion_r716075956



##########
File path: commons-math-ga/pom.xml
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0"?>
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+	<parent>
+		<groupId>org.apache.commons</groupId>
+		<artifactId>commons-math-parent</artifactId>
+		<version>4.0-SNAPSHOT</version>
+	</parent>
+	<artifactId>commons-math4-ga</artifactId>

Review comment:
       Remove the 4 from math4. The version is specified separately from the artifact ID.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] coveralls commented on pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #197:
URL: https://github.com/apache/commons-math/pull/197#issuecomment-926462621


   
   [![Coverage Status](https://coveralls.io/builds/43044584/badge)](https://coveralls.io/builds/43044584)
   
   Coverage decreased (-0.4%) to 90.08% when pulling **e6157253dc3071b661814e838065ffe0e37feb19 on avijitbasak:feature/MATH-1563** into **470bdbb5f35ddde4935ed32529386f36b656213e on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] coveralls edited a comment on pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #197:
URL: https://github.com/apache/commons-math/pull/197#issuecomment-926462621


   
   [![Coverage Status](https://coveralls.io/builds/43083592/badge)](https://coveralls.io/builds/43083592)
   
   Coverage decreased (-0.04%) to 90.418% when pulling **4b094b2d81c07f7cad203d2c3a54b71163633dd6 on avijitbasak:feature/MATH-1563** into **470bdbb5f35ddde4935ed32529386f36b656213e on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] coveralls edited a comment on pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #197:
URL: https://github.com/apache/commons-math/pull/197#issuecomment-926462621


   
   [![Coverage Status](https://coveralls.io/builds/43066987/badge)](https://coveralls.io/builds/43066987)
   
   Coverage decreased (-0.4%) to 90.086% when pulling **5b32d9a9c12f0a02edb54144ad58c9bbf6ff8bcf on avijitbasak:feature/MATH-1563** into **470bdbb5f35ddde4935ed32529386f36b656213e on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] coveralls edited a comment on pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #197:
URL: https://github.com/apache/commons-math/pull/197#issuecomment-926462621


   
   [![Coverage Status](https://coveralls.io/builds/43067045/badge)](https://coveralls.io/builds/43067045)
   
   Coverage decreased (-0.4%) to 90.086% when pulling **39db7ca37df35137eda6003c2a0282f8c18fdec3 on avijitbasak:feature/MATH-1563** into **470bdbb5f35ddde4935ed32529386f36b656213e on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] avijitbasak closed pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
avijitbasak closed pull request #197:
URL: https://github.com/apache/commons-math/pull/197


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] coveralls edited a comment on pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #197:
URL: https://github.com/apache/commons-math/pull/197#issuecomment-926462621


   
   [![Coverage Status](https://coveralls.io/builds/43072746/badge)](https://coveralls.io/builds/43072746)
   
   Coverage decreased (-0.4%) to 90.097% when pulling **e084eb6cb71743927759bbc45daa8cb88e145826 on avijitbasak:feature/MATH-1563** into **470bdbb5f35ddde4935ed32529386f36b656213e on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] avijitbasak commented on a change in pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
avijitbasak commented on a change in pull request #197:
URL: https://github.com/apache/commons-math/pull/197#discussion_r716221065



##########
File path: commons-math-ga/pom.xml
##########
@@ -0,0 +1,54 @@
+<?xml version="1.0"?>
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+	<parent>
+		<groupId>org.apache.commons</groupId>
+		<artifactId>commons-math-parent</artifactId>
+		<version>4.0-SNAPSHOT</version>
+	</parent>
+	<artifactId>commons-math4-ga</artifactId>

Review comment:
       Done and committed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] avijitbasak commented on pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
avijitbasak commented on pull request #197:
URL: https://github.com/apache/commons-math/pull/197#issuecomment-922933961


   The following errors have been received after build. These are due to formatting of lambda expression. Need help to resolve this.
   [INFO] There are 6 errors reported by Checkstyle 8.29 with /home/travis/build/apache/commons-math/commons-math4-genetics/../src/main/resources/checkstyle/checkstyle.xml ruleset.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/selection/TournamentSelectionTest.java:[51] (indentation) Indentation: 'block' child has incorrect indentation level 16, expected level should be 20.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/selection/TournamentSelectionTest.java:[52] (indentation) Indentation: 'block rcurly' has incorrect indentation level 12, expected level should be 16.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/dummy/DummyChromosome.java:[27] (indentation) Indentation: 'block' child has incorrect indentation level 12, expected level should be 16.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/dummy/DummyChromosome.java:[28] (indentation) Indentation: 'block rcurly' has incorrect indentation level 8, expected level should be 12.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/utils/ChromosomeRepresentationUtilsTest.java:[114] (indentation) Indentation: 'block' child has incorrect indentation level 20, expected level should be 12.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/utils/ChromosomeRepresentationUtilsTest.java:[115] (indentation) Indentation: 'block rcurly' has incorrect indentation level 16, expected level should be 8.
   [INFO] ------------------------------------------------------------------------
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-math] avijitbasak edited a comment on pull request #197: Feature/math 1563

Posted by GitBox <gi...@apache.org>.
avijitbasak edited a comment on pull request #197:
URL: https://github.com/apache/commons-math/pull/197#issuecomment-922933961


   The following errors have been received after build. These are due to formatting of lambda expression. I have formatted the manually. It will be helpful if anyone can share eclipse configuration to resolve this.
   
   [INFO] There are 6 errors reported by Checkstyle 8.29 with /home/travis/build/apache/commons-math/commons-math4-genetics/../src/main/resources/checkstyle/checkstyle.xml ruleset.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/selection/TournamentSelectionTest.java:[51] (indentation) Indentation: 'block' child has incorrect indentation level 16, expected level should be 20.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/selection/TournamentSelectionTest.java:[52] (indentation) Indentation: 'block rcurly' has incorrect indentation level 12, expected level should be 16.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/dummy/DummyChromosome.java:[27] (indentation) Indentation: 'block' child has incorrect indentation level 12, expected level should be 16.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/dummy/DummyChromosome.java:[28] (indentation) Indentation: 'block rcurly' has incorrect indentation level 8, expected level should be 12.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/utils/ChromosomeRepresentationUtilsTest.java:[114] (indentation) Indentation: 'block' child has incorrect indentation level 20, expected level should be 12.
   [ERROR] src/test/java/org/apache/commons/math4/genetics/utils/ChromosomeRepresentationUtilsTest.java:[115] (indentation) Indentation: 'block rcurly' has incorrect indentation level 16, expected level should be 8.
   [INFO] ------------------------------------------------------------------------
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org