You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by zellerh <gi...@git.apache.org> on 2018/03/01 17:21:02 UTC
[GitHub] trafodion pull request #1460: [TRAFODION-2974] Make event log reader and JDB...
GitHub user zellerh opened a pull request:
https://github.com/apache/trafodion/pull/1460
[TRAFODION-2974] Make event log reader and JDBC real TMUDFs
Roberta pointed out that we have two predefined UDFs, EVENT_LOG_READER
and JDBC, where the system administrator should have the ability to
control who can execute these functions.
To do this, these two UDFs cannot be "predefined" UDFs anymore, since
those don't have the metadata that's required for doing grant and
revoke.
Roberta also pointed out that the JDBC UDF should refuse to connect to
the T2 driver, for security reasons.
The fix leaves the predefined TMUDFs in place, for now, they will be
removed in R2.4 (see TRAFODION-2975).
The new "real" TMUDFs are in the "_LIBMGR_" schema, mostly for
convenience, as this schema has other UDFs that are created when
Trafodion is initialized.
Note for reviewers: The new JDBCUDR.java file is the same as the existing file, except for the package name and for the note added to the old file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zellerh/trafodion bug/R23a
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1460.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1460
----
commit 562a7bdf95e2cee26e9f77b9269c05b8c2ad162a
Author: Hans Zeller <hz...@...>
Date: 2018-03-01T17:03:01Z
[TRAFODION-2974] Make event log reader and JDBC real TMUDFs
Roberta pointed out that we have two predefined UDFs, EVENT_LOG_READER
and JDBC, where the system administrator should have the ability to
control who can execute these functions.
To do this, these two UDFs cannot be "predefined" UDFs anymore, since
those don't have the metadata that's required for doing grant and
revoke.
Roberta also pointed out that the JDBC UDF should refuse to connect to
the T2 driver, for security reasons.
The fix leaves the predefined TMUDFs in place, for now, they will be
removed in R2.4 (see TRAFODION-2975).
The new "real" TMUDFs are in the "_LIBMGR_" schema, mostly for
convenience, as this schema has other UDFs that are created when
Trafodion is initialized.
----
---
[GitHub] trafodion pull request #1460: [TRAFODION-2974] Make event log reader and JDB...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1460
---
[GitHub] trafodion pull request #1460: [TRAFODION-2974] Make event log reader and JDB...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1460#discussion_r172066807
--- Diff: core/sql/bin/SqlciErrors.txt ---
@@ -1331,6 +1331,7 @@ $1~String1 --------------------------------
4320 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Stream access is not allowed on multi-partitioned table or index, when flag ATTEMPT_ASYNCHRONOUS_ACCESS is set to OFF. Object in scope: $0~TableName.
4321 ZZZZZ 99999 BEGINNER MAJOR DBADMIN An embedded update/delete is not allowed on a partitioned table, when flag ATTEMPT_ASYNCHRONOUS_ACCESS is set to OFF. Object in scope: $0~TableName.
4322 0A000 99999 BEGINNER MAJOR DBADMIN A column with BLOB datatype cannot be used in this clause or function.
+4323 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Use of predefined UDF $0~String0 is deprecated and this function will be removed in a future release. Please use the function with the same name in schema TRAFODION."_LIBMGR_" instead. You may need to issue this command first: INITIALIZE TRAFODION, UPGRADE LIBRARY MANAGEMENT.
--- End diff --
Consider adding this message to the Trafodion Messages Guide.
---