You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2020/12/12 09:44:43 UTC

[GitHub] [curator] iwangjie commented on a change in pull request #375: CURATOR-585: fix DiscoveryExample did not check for exceptions

iwangjie commented on a change in pull request #375:
URL: https://github.com/apache/curator/pull/375#discussion_r541542988



##########
File path: curator-examples/src/main/java/discovery/DiscoveryExample.java
##########
@@ -192,8 +194,13 @@ private static void listInstances(ServiceDiscovery<InstanceDetails> serviceDisco
                 }
             }
         }
-        finally

Review comment:
       OK, thank you. I'll put the resource shutdown in the finally block.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org