You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Chet Murthy <mu...@gmail.com> on 2013/04/24 03:40:02 UTC
latest Thrift master fails to build on Ubunu Precise x86
I checked out the latest Thrift master, and it wouldn't build. The
error I got pointed at a missing include. Is this the sort of thing
that one creates an issue for? Or posts?
Also, I ran "make check" after building, and the only that failed was
TransportTest, which hung. But then, it hung at the same place on the
0.9 release code.
--chet--
commit 6bdb10b592853fa036ff656032adb03d4b1a3ef4
Author: jfarrell <jf...@apache.org>
Date: Tue Apr 23 15:42:04 2013 -0500
Thrift-1942: Binary accelerated cpp extension does not use Thrift
namespaces
Client: php
Patch: Tyler Hobbs
Adds namespaced TException to the accelerated php client lib.
================================================================
--- a/lib/cpp/src/thrift/server/TNonblockingServer.cpp
+++ b/lib/cpp/src/thrift/server/TNonblockingServer.cpp
@@ -23,6 +23,7 @@
#include <config.h>
#endif
+#include "thrift/cxxfunctional.h"
#include "TNonblockingServer.h"
#include <thrift/concurrency/Exception.h>
#include <thrift/transport/TSocket.h>
Re: latest Thrift master fails to build on Ubunu Precise x86
Posted by Chet Murthy <mu...@gmail.com>.
I went back and carefully attempted to reproduce this failure. It
does not recur. Please ignore the subject email.
On Tuesday, April 23, 2013 06:40:02 PM Chet Murthy wrote:
> I checked out the latest Thrift master, and it wouldn't build. The
> error I got pointed at a missing include. Is this the sort of thing
> that one creates an issue for? Or posts?
>
> Also, I ran "make check" after building, and the only that failed was
> TransportTest, which hung. But then, it hung at the same place on the
> 0.9 release code.
>
> --chet--
>
> commit 6bdb10b592853fa036ff656032adb03d4b1a3ef4
> Author: jfarrell <jf...@apache.org>
> Date: Tue Apr 23 15:42:04 2013 -0500
>
> Thrift-1942: Binary accelerated cpp extension does not use Thrift
> namespaces
> Client: php
> Patch: Tyler Hobbs
>
> Adds namespaced TException to the accelerated php client lib.
>
> ================================================================
> --- a/lib/cpp/src/thrift/server/TNonblockingServer.cpp
> +++ b/lib/cpp/src/thrift/server/TNonblockingServer.cpp
> @@ -23,6 +23,7 @@
> #include <config.h>
> #endif
>
> +#include "thrift/cxxfunctional.h"
> #include "TNonblockingServer.h"
> #include <thrift/concurrency/Exception.h>
> #include <thrift/transport/TSocket.h>
Re: latest Thrift master fails to build on Ubunu Precise x86
Posted by Randy Abernethy <Ra...@rx-m.com>.
Hi Chet,
Not sure about the build problem. I have seen the make check problem
however.
If THRIFT-1850 is what you are seeing (sounds like it) the 1850 patch
may fix it.
This patch has not been committed yet so you will have to apply it manually.
Best,
Randy
On 4/23/2013 6:40 PM, Chet Murthy wrote:
> I checked out the latest Thrift master, and it wouldn't build. The
> error I got pointed at a missing include. Is this the sort of thing
> that one creates an issue for? Or posts?
>
> Also, I ran "make check" after building, and the only that failed was
> TransportTest, which hung. But then, it hung at the same place on the
> 0.9 release code.
>
> --chet--
>
> commit 6bdb10b592853fa036ff656032adb03d4b1a3ef4
> Author: jfarrell <jf...@apache.org>
> Date: Tue Apr 23 15:42:04 2013 -0500
>
> Thrift-1942: Binary accelerated cpp extension does not use Thrift
> namespaces
> Client: php
> Patch: Tyler Hobbs
>
> Adds namespaced TException to the accelerated php client lib.
>
> ================================================================
> --- a/lib/cpp/src/thrift/server/TNonblockingServer.cpp
> +++ b/lib/cpp/src/thrift/server/TNonblockingServer.cpp
> @@ -23,6 +23,7 @@
> #include <config.h>
> #endif
>
> +#include "thrift/cxxfunctional.h"
> #include "TNonblockingServer.h"
> #include <thrift/concurrency/Exception.h>
> #include <thrift/transport/TSocket.h>
>
--
Randy Abernethy
Managing Partner, RX-M, LLC
randy.abernethy@rx-m.com
Cell: +1-415-624-6447
San Francisco: +1-415-800-2922
Tokyo: +81-50-5532-8040
www.rx-m.com
@rxmllc