You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/03 00:18:29 UTC

[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19284: Fix Nightly CD

Zha0q1 opened a new pull request #19284:
URL: https://github.com/apache/incubator-mxnet/pull/19284


   There is a minor command generation bug with cd pipeline. link: https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-mxnet-cd%2Fmxnet-cd-release-job/detail/mxnet-cd-release-job/1800/pipeline
   
   Thanks @mseth10 for point out the direction. Quoting his comments:
   ```
   Looks like this commit caused the failure: https://github.com/apache/incubator-mxnet/commit/d81692933f507e7631cbbbb8be920f02eaeaa585
   
   More specifically, changes to env_vars in docker_run function in file ci/Jenkinsfile_utils.groovy, which gets called for the CD pipeline here:
   https://github.com/apache/incubator-mxnet/blob/7d3e027846b2767e330d488092e0c12b2d01b36d/cd/python/pypi/Jenkins_pipeline.groovy#L52
   
   The CD pipeline:
   https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-mxnet-cd%2Fmxnet-cd-release-job/detail/mxnet-cd-release-job/1775/pipeline/331
   
   - ran this command (faulty) after the commit got merged:
   `ci/build.py -e R -e E -e L -e E -e A -e S -e E -e _ -e B -e U -e I -e L -e D -e = -e  -e t -e r -e u -e e -e  --docker-registry mxnetci --nvidiadocker --platform centos7_gpu_cu102 --docker-build-retries 3 --shm-size 500m /work/runtime_functions.sh cd_package_pypi cu102`
   
   - ran this command (correct) before the commit got merged:
   `ci/build.py -e RELEASE_BUILD=true --docker-registry mxnetci --nvidiadocker --platform centos7_gpu_cu102 --docker-build-retries 3 --shm-size 500m /work/runtime_functions.sh cd_package_pypi cu102`
   ```
   
   So basically if we are not specifying `env_vars` then its default value is `[]`, no problem. But if we pass in String obj then `env_vars = env_vars.collect { "-e ${it}" }` will break the string into letters. So we need to add:
   ```
   if (env_vars instanceof String) {
       env_vars = [env_vars]
   }
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19284: Fix Nightly CD

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19284:
URL: https://github.com/apache/incubator-mxnet/pull/19284#issuecomment-703010419


   Hey @Zha0q1 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-gpu, windows-cpu, unix-cpu, website, centos-gpu, sanity, edge, windows-gpu, miscellaneous, centos-cpu, clang]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] szha merged pull request #19284: Fix Nightly CD

Posted by GitBox <gi...@apache.org>.
szha merged pull request #19284:
URL: https://github.com/apache/incubator-mxnet/pull/19284


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org