You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tzolov <gi...@git.apache.org> on 2015/09/09 01:46:32 UTC

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

GitHub user tzolov opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/291

    Zeppelin-275: Add SpringXD Stream and Job Interpreters

    ## 1. SpringXD Stream Interpreter:
    * %**xd.stream** - identifies the SpringXD Streams interpreter.
    * Use (Ctrl+.) for auto-completion.
    * Streams must have names. Follow the convention:  (stream name = stream definition). Streams without names are ignored. 
    * New **Run** destroys any previous streams created in the same paragraph. The previous streams are destroyed even if their names have been changed or removed.
    * New **Run** will **Create** and automatically **Deploy** all streams defined in the Paragraph.
    * If one stream fails to create or deploy all streams in the paragraph are destroyed
    * Zeppelin returns after the streams deployment (e.g. Zeppelin goes into **Finished** state). 
    * When streams have successfully been deployed the result contains a button that lists the just deployed streams and status 'DEPLOYED'
    * To destroy streams in the paragraph press the Annular button in the result section. Button state should switch from 'DEPLOYED' to 'DESTROYED'.
    * Streams can refer other streams or jobs in any paragraph and even different notebooks
    
    ## 2. SpringXD Job Interpreter:
    * %**xd.job** - identifies the SpringXD Job interpreter.
    * Use (Ctrl+.) for auto-completion.
    * Jobs must have names. Follow the convention:  (job name = job definition). Streams without names are ignored. 
    * New **Run** destroys any previous jobs created in the same paragraph. The previous jobs are destroyed even if their names have been changed or removed.
    * New **Run** will **Create** and automatically **Deploy** and **Start** all jobs defined in the Paragraph.
    * If one job deployment fail all jobs in the paragraph are destroyed
    * Zeppelin returns after the jobs have started (e.g. Zeppelin goes into  **Finished** state). 
    * When job have successfully been deployed the result contains a button that lists the just deployed jobs and status 'DEPLOYED'
    * To destroy all jobs in the paragraph, press the Annular button in the result section. Button state should switch from 'DEPLOYED' to 'DESTROYED'.
    * Jobs can refer other streams or jobs in any paragraph and even different notebooks

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzolov/incubator-zeppelin ZEPPELIN-275

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #291
    
----
commit 3a43491295e1dd7b4e1ab3e1238df87b25c080f9
Author: tzolov <ch...@gmail.com>
Date:   2015-08-12T21:34:50Z

    ZEPPELIN-219: Paragaph mode auto-detection - initial impl

commit bc3758c19cff34bc5db835cd09287d4910376d36
Author: tzolov <ch...@gmail.com>
Date:   2015-08-13T07:36:24Z

    ZEPPELIN-219: Add paragraph text as setPargraphMode() argument

commit 1e2f482c516d1cc367a60b8094a3c056a0d644e1
Author: Damien Corneau <co...@gmail.com>
Date:   2015-08-26T08:31:27Z

    Change setParagraphMode function

commit 389d8af45c7872fd6c3734ebcdef94f1a502e122
Author: Damien Corneau <co...@gmail.com>
Date:   2015-08-27T03:40:12Z

    Improve loop performances

commit 5a5d646df83007c90b494d3985c0dc47db0fa3ca
Author: tzolov <ch...@gmail.com>
Date:   2015-08-28T10:07:22Z

    ZEPPELIN-275: Add SpringXD Stream Interpreter

commit 2005603e86f38944d22a198cd04f2416de334e59
Author: tzolov <ch...@gmail.com>
Date:   2015-08-31T13:58:46Z

    ZEPPELIN-275: Add angular button to destroy paragraph streams

commit 19fb574268084b71ffd60f360fa46fa9cd41174f
Author: tzolov <ch...@gmail.com>
Date:   2015-09-01T18:01:27Z

    ZEPPELIN-275: Add SpringXD Job Interpreter. Refactor the code to abstract parts common for Stream and Job interpreters.

commit d24187da621a537fef202e5363ea2d5c29c22742
Author: tzolov <ch...@gmail.com>
Date:   2015-09-02T08:22:35Z

    ZEPPELIN-275: Add unit tests

commit 5b14c894957b3bd13ff9bf5b33f11e34ced29afc
Author: tzolov <ch...@gmail.com>
Date:   2015-09-03T11:56:46Z

    ZEPPELIN-275: Improve unit test coverage

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-172001176
  
    Great!  
    Quick question - do we need to add this interpreters to the list of interpreters in docs? (They now live in master, under `./docs`)
    
    Also, as they become part of releases - are there any new dependency that it brings, that need to be added to `zeppelin-distribution/src/bin_license/LICENSE` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-172710903
  
    Looks great to me, thank you! Just needed to be updated on top of the latest master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-171923348
  
    @bzz, i've resolved the commits mix-up, please review.
    Also i've rebased the ZEPPELIN-275 branch to the master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-168951342
  
    Looks like this guy diverged from master as well as having some commits that are not part of 	ZEPPELIN-275 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-172358958
  
    Cheers @bzz,
    I've updated the LICENSE file with the springxd dependecy. Also i've put together a basic springxd documentation page and listed it in the interpreter's menu. Let me know if we are still missing tasks.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-172207982
  
    Sounds great, thank you very much!
    
    On Sat, Jan 16, 2016 at 3:14 AM, Christian Tzolov <no...@github.com>
    wrote:
    
    >
    >    - Sure the interpreter should have documentation - I will add such to
    >    the ./docs
    >    - The interpreter brings 2 deps: spring-xd-rest-client (under Apache2
    >    License) which i will add to the LICENSE file and Guava - already there
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-172040745>
    > .
    >
    
    
    
    -- 
    --
    Kind regards,
    Alexander.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-172481467
  
    Thanks @AhyoungRyu! I've just commited a fix for the abovementioned misspellings. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-172040745
  
    - Sure the interpreter should have documentation - I will add such to the ./docs
    - The interpreter brings 2 deps:  spring-xd-rest-client (under Apache2 License) which i will add to the LICENSE file and Guava - already there


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-275: Add SpringXD Stream...

Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/291#issuecomment-168968189
  
    Good spot @bzz, I will try to clear the ghost commits.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---