You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by xt...@apache.org on 2022/08/11 09:48:39 UTC

[flink] 01/02: [FLINK-28884] HsSubpartitionView should be initialized to a notifiable state.

This is an automated email from the ASF dual-hosted git repository.

xtsong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 0f376641e88794ab499f0203be4820696694eba7
Author: Weijie Guo <re...@163.com>
AuthorDate: Fri Aug 5 10:33:23 2022 +0800

    [FLINK-28884] HsSubpartitionView should be initialized to a notifiable state.
    
    HsSubpartitionView should be initialized to a notifiable state, there may be a problem of never consuming otherwise. Imagine the following situation: Downstream task has no initial credit(i.e. exclusive buffers is configured to zero), if there is no data output in the upstream, it will feedback a zero backlog to downstream input channel. All subsequent data available notifications will be intercepted as needNotify is false.
---
 .../flink/runtime/io/network/partition/hybrid/HsSubpartitionView.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSubpartitionView.java b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSubpartitionView.java
index a56947b0e01..e40bcbf6b4f 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSubpartitionView.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSubpartitionView.java
@@ -43,7 +43,7 @@ public class HsSubpartitionView
     private int lastConsumedBufferIndex = -1;
 
     @GuardedBy("lock")
-    private boolean needNotify = false;
+    private boolean needNotify = true;
 
     @Nullable
     @GuardedBy("lock")