[GitHub] [tinkerpop] spmallette opened a new pull request #1211: TINKERPOP-1568 Changed Strategy Application Methodology

[GitBox <gi...@apache.org>]

spmallette opened a new pull request #1211: TINKERPOP-1568 Changed Strategy Application Methodology
URL: https://github.com/apache/tinkerpop/pull/1211
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-1568
   
   Please refer to the JIRA issue for details as well as the Upgrade Docs on this PR for more information about this one. I'm generally happy with how few changes were actually involved in making this happen - if you take away my light refactoring for inclusion of the `IsRoot()` method very few files had to really change and for the most part the changes themselves were fairly straightforward. It didn't always look this way - took a fair amount of effort to get to the root of why certain changes were necessary to then refactor for greater simplicity. 
   
   I think the only thing I wasn't really able to sort out "nicely" was `MessagePassingReductionStrategy`. It seems to need to know a lot about `profile()` for some reason and I wasn't quite able to sort out a better way to do what was necessary there. I think I'm just going to have to submit that as-is unless someone has better ideas.
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services