Re: [PR] Add and distribute IQv2 information in KIP-1071 [kafka]

["bbejeck (via GitHub)" <gi...@apache.org>]

bbejeck commented on code in PR #18278:
URL: https://github.com/apache/kafka/pull/18278#discussion_r1911573303


##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java:
##########
@@ -78,24 +80,28 @@ public class OptimizedKTableIntegrationTest {
     private static final String INPUT_TOPIC_NAME = "input-topic";
     private static final String TABLE_NAME = "source-table";
 
-    public static final EmbeddedKafkaCluster CLUSTER = new EmbeddedKafkaCluster(NUM_BROKERS);
+    public static EmbeddedKafkaCluster cluster;
 
     @BeforeAll
     public static void startCluster() throws IOException {
-        CLUSTER.start();
+        final Properties props = new Properties();
+        props.setProperty(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, "classic,consumer,streams");

Review Comment:
   @lucasbru thinking about this more, I think it would be OK to have all the tests set the protocols accepted by the broker to all the available ones.  The parameterization should be in the Kafka Streams configuration specifying to use either the `classic` or `streams` protocol.  WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org